diff --git a/src/main/java/org/folio/circulation/domain/validation/ServicePointPickupLocationValidator.java b/src/main/java/org/folio/circulation/domain/validation/ServicePointPickupLocationValidator.java index 0fbd87010d..3dc229c4ff 100644 --- a/src/main/java/org/folio/circulation/domain/validation/ServicePointPickupLocationValidator.java +++ b/src/main/java/org/folio/circulation/domain/validation/ServicePointPickupLocationValidator.java @@ -24,7 +24,7 @@ public Result refuseInvalidPickupServicePoint( Request request = null; if (requestAndRelatedRecords != null) { - log.info("refuseInvalidPickupServicePoint:: requestAndRelatedRecords is null"); + log.info("refuseInvalidPickupServicePoint:: requestAndRelatedRecords is not null"); request = requestAndRelatedRecords.getRequest(); } diff --git a/src/main/java/org/folio/circulation/resources/RequestByInstanceIdResource.java b/src/main/java/org/folio/circulation/resources/RequestByInstanceIdResource.java index 1df9575fb5..6a6d0f5227 100644 --- a/src/main/java/org/folio/circulation/resources/RequestByInstanceIdResource.java +++ b/src/main/java/org/folio/circulation/resources/RequestByInstanceIdResource.java @@ -1,5 +1,7 @@ package org.folio.circulation.resources; +import static java.lang.String.format; +import static java.lang.String.join; import static java.util.stream.Collectors.toList; import static org.folio.circulation.domain.InstanceRequestItemsComparer.sortRequestQueues; import static org.folio.circulation.domain.RequestFulfillmentPreference.HOLD_SHELF; @@ -300,10 +302,12 @@ private CompletableFuture> placeRequest( startIndex, itemRequests.size()); if (startIndex >= itemRequests.size()) { - String aggregateFailures = String.format("%n%s", String.join("%n", errors)); + log.error("Failed to place a request for the instance. Reasons: {}", errors); - return CompletableFuture.completedFuture(failedDueToServerError( - "Failed to place a request for the instance. Reasons: " + aggregateFailures)); + return CompletableFuture.completedFuture(failedValidation( + errors.stream() + .map(ValidationError::new) + .collect(toList()))); } JsonObject currentItemRequest = itemRequests.get(startIndex);