diff --git a/src/components/package/show/package-show.css b/src/components/package/show/components/PackageTitleList/PackageTitleList.css similarity index 89% rename from src/components/package/show/package-show.css rename to src/components/package/show/components/PackageTitleList/PackageTitleList.css index d1299e53e..d4f3bddee 100644 --- a/src/components/package/show/package-show.css +++ b/src/components/package/show/components/PackageTitleList/PackageTitleList.css @@ -2,5 +2,6 @@ .titlesListContainer { max-width: calc(var(--container-max-width) - 2rem); + height: 560px; margin: 0 auto; } diff --git a/src/components/package/show/components/PackageTitleList/PackageTitleList.js b/src/components/package/show/components/PackageTitleList/PackageTitleList.js index 6ddbc7328..cdcf45439 100644 --- a/src/components/package/show/components/PackageTitleList/PackageTitleList.js +++ b/src/components/package/show/components/PackageTitleList/PackageTitleList.js @@ -12,7 +12,7 @@ import InternalLink from '../../../../internal-link'; import CoverageDateList from '../../../../coverage-date-list'; import { isBookPublicationType } from '../../../../utilities'; -import styles from '../../package-show.css'; +import styles from './PackageTitleList.css'; const COLUMNS = { STATUS: 'status', @@ -22,7 +22,7 @@ const COLUMNS = { MANAGED_EMBARGO: 'managedEmbargo', }; -const MAX_HEIGHT = 526; +const MAX_HEIGHT = 520; const propTypes = { count: PropTypes.number.isRequired, diff --git a/src/routes/package-show-route/package-show-route.js b/src/routes/package-show-route/package-show-route.js index deeb602cb..bef0d9e9c 100644 --- a/src/routes/package-show-route/package-show-route.js +++ b/src/routes/package-show-route/package-show-route.js @@ -3,7 +3,6 @@ import PropTypes from 'prop-types'; import ReactRouterPropTypes from 'react-router-prop-types'; import queryString from 'qs'; import isEqual from 'lodash/isEqual'; -import reduce from 'lodash/reduce'; import { TitleManager } from '@folio/stripes/core'; @@ -25,7 +24,6 @@ class PackageShowRoute extends Component { static propTypes = { accessStatusTypes: accessTypesReduxStateShape.isRequired, clearCostPerUseData: PropTypes.func.isRequired, - clearPackageTitles: PropTypes.func.isRequired, costPerUse: costPerUseShape.CostPerUseReduxStateShape.isRequired, destroyPackage: PropTypes.func.isRequired, getAccessTypes: PropTypes.func.isRequired, @@ -282,17 +280,8 @@ class PackageShowRoute extends Component { const { location, history, - clearPackageTitles, } = this.props; - const paramDifference = reduce(pkgSearchParams, (result, item, key) => { - return isEqual(item, this.state.pkgSearchParams[key]) ? result : result.concat(key); - }, []); - - if (!(paramDifference.length === 1 && paramDifference[0] === 'page')) { - clearPackageTitles(); - } - const qs = queryString.parse(location.search, { ignoreQueryPrefix: true }); const search = queryString.stringify({ ...qs, diff --git a/src/routes/package-show-route/package-show-route.test.js b/src/routes/package-show-route/package-show-route.test.js index ec9d39559..9929715ec 100644 --- a/src/routes/package-show-route/package-show-route.test.js +++ b/src/routes/package-show-route/package-show-route.test.js @@ -567,8 +567,8 @@ describe('Given PackageShowRoute', () => { }); }); - describe('when changed param is not single and it is not "page"', () => { - it('should handle clearPackageTitles', async () => { + describe('when packages are being fetched', () => { + it('should not clear old ones', async () => { const { getByRole, } = renderPackageShowRoute({ @@ -586,7 +586,7 @@ describe('Given PackageShowRoute', () => { await userEvent.type(searchBox, 'Title name{enter}'); - expect(mockClearPackageTitles).toHaveBeenCalled(); + expect(mockClearPackageTitles).not.toHaveBeenCalled(); }); }); });