Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not switch to the Output panel when deploy on save is enabled #5903

Closed
tehnrd opened this issue Oct 18, 2024 · 4 comments
Closed

Do not switch to the Output panel when deploy on save is enabled #5903

tehnrd opened this issue Oct 18, 2024 · 4 comments
Labels
feature type:enhancements Feedback to take into account for existing features

Comments

@tehnrd
Copy link
Contributor

tehnrd commented Oct 18, 2024

Is your feature request related to a problem? Please describe.
When the "Push-or-deploy-on-save" setting is enabled, I’m always frustrated when I save a file, and VSCode changes the panel to the Output panel when saving the record. This completely disrupted the development experiences.

Describe the solution you'd like
By default, when "Push-or-deploy-on-save" is enabled, the UI should not switch to the Output panel when the files are saved. A setting can override this default behavior and show the Output panel if the user wants this behavior.

Describe alternatives you've considered
I am unaware of any alternatives to changing the output panel behavior when “Push-or-deploy-on-save” is enabled.

Additional context
This feature has been requested in some form many times and has attempted to be addressed in PRs.
Issue: #1429
Issue: #1110
PR: #4337
PR: #4971
PR: #1865
PR: #1181

The PRs to address this issue have had regressions, which no longer work. Some of the feedback on other PRs was that a global setting for suppressing output panel switching was too aggressive, so this suggestion is for Push-or-deploy-on-save only.

Here is a video showing the before and after functionality:
https://www.loom.com/share/a59adaa191474e64a835e9d52121f6c3?sid=7d8250d5-8e2d-4904-afda-6f0d05888f79

@svc-idee-bot svc-idee-bot added the type:enhancements Feedback to take into account for existing features label Oct 18, 2024
@svc-idee-bot
Copy link
Collaborator

Thank you for filing this feature request. We appreciate your feedback and will review the feature at our next grooming session. We prioritize feature requests with more upvotes and comments.

@tehnrd
Copy link
Contributor Author

tehnrd commented Oct 18, 2024

There is also a perspective to put forward in which there should be no setting at all, and by default, the UI simply does not change to the Output panel at all with Push-or-deploy-on-save enabled.

Copy link

git2gus bot commented Nov 11, 2024

This issue has been linked to a new work item: W-17206953

@mingxuanzhangsfdx
Copy link
Member

Hi @tehnrd thanks for putting up the PR. it has been merged and will get into next week's release. I know there are some discussions still around. If you are still interested in further enhancement, please let us know so we could specify the requirements. Due to business need, we do not have enough bandwidth developing this area for now. We really appreciate your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature type:enhancements Feedback to take into account for existing features
Projects
None yet
Development

No branches or pull requests

3 participants