Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for lrucache #11

Closed
wants to merge 0 commits into from
Closed

Added unit tests for lrucache #11

wants to merge 0 commits into from

Conversation

suja1956
Copy link

This PR contains unit tests for lrucache.go file.
Below are the unit tests that I have added:

  1. TestOverwriteValue: Tests that if a value is set for an existing key, the value is properly overwritten.
  2. TestEviction: Verifies that when the cache exceeds its capacity, the least recently used item is evicted. This test uses a cache of size 2 to simulate the eviction.
  3. TestMoveToFront: Ensures that when an item is accessed, it becomes the most recently used item. The least recently used item should be evicted after inserting a new one.
  4. TestLRUBehavior: Tests more advanced LRU behavior by accessing different items and confirming that the least recently accessed item is the one that gets evicted when the cache is full.

Fixes: #10

@yp969803
Copy link
Collaborator

@suja1956 run 'make format' before commiting, also the tests are failing

@yp969803 yp969803 self-requested a review September 24, 2024 22:25
@yp969803
Copy link
Collaborator

also you can remove

wharf/pkg/cache/lrucache_test.go

Line 7 in ad512ce

func TestGetSet(t *testing.T) {

yp969803
yp969803 reviewed Sep 24, 2024
View reviewed changes
pkg/cache/lrucache_test.go Outdated

val = cache.Get("key1")
if val != nil {
t.Errorf("Expected nil (key1 evicted), got %s", val)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failing here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try to resolve.

@yp969803
Copy link
Collaborator

@suja1956 can you pull the current main branch, i have done some changes in lrucache functions

@suja1956 suja1956 closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp969803 yp969803 yp969803 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write unit tests for pkg/cache/lrucache.go
2 participants
@suja1956 @yp969803