Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk_export embeds information in string #138

Open
mattholc opened this issue Jul 11, 2024 · 1 comment
Open

mk_export embeds information in string #138

mattholc opened this issue Jul 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mattholc
Copy link
Collaborator

If you create a mol from an sdf generated by mk_export, it has only the property 'meeko' which contains a dictionary of docking information ('is_sidechain', 'free_energy', etc) formatted as a string. It would be preferable to expose direct access to the properties through rdkit molprops.

mol.GetProp('meeko')
'{"is_sidechain": [false], "free_energy": -8.3, "intermolecular_energy": -12.48, "internal_energy": -8.1, "cluster_size": 13, "cluster_id": 4, "rank_in_cluster": 1}'

type(mol.GetProp('meeko'))
<class 'str'>

@mattholc mattholc added the enhancement New feature or request label Jul 11, 2024
@diogomart
Copy link
Contributor

I think the only reason to wrap the data in a json str was to prevent future name collisions. We might have a mixture of energies in the future from QM, scrubber, pka prediction, and so on. Could also use the name of the property to that end. Not sure if one way is better than the other. Currently, you can pass that string to json.loads() to get the dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants