Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it simpler to extend nix-bitcoin #224

Open
jonasnick opened this issue Aug 16, 2020 · 5 comments
Open

Make it simpler to extend nix-bitcoin #224

jonasnick opened this issue Aug 16, 2020 · 5 comments
Labels
enhancement New feature or request Mid Term

Comments

@jonasnick
Copy link
Member

jonasnick commented Aug 16, 2020

There are many more packages and modules I would like to experiment with on my nix-bitcoin node. It seems like there's at least half a dozen usable frontends for lnd. However, maintaining all of this in this repo does not really scale. That's evident from the time it takes for some PRs to get reviews. Ideally, nix-bitcoin would be very minimal - perhaps only bitcoind, clightning and lnd as well as the secrets, netns, test, etc infrastructure) - and allow external repos to use these capabilities and add their own packages/modules.

As far as I understand, the (currently experimental) flakes features was invented in part because the nixpkgs repo does not scale and it's planned to split it up. Similarly, if we want to go forward with this issue we should look into how flakes as a standard way to compose nix expressions can help with that.

@jonasnick jonasnick added enhancement New feature or request Mid Term labels Aug 16, 2020
@nixbitcoin
Copy link
Member

Concept ACK

@jonasnick
Copy link
Member Author

When looking at the btcpayserver module we can see that the main modules that need additional changes in order to add a module are

  • backup
  • nodeinfo
  • netns

We should refactor these modules to provide options that achieve the same without having to touch the module. For example, in case of the backup module we want an option that allows adding directories to back up.

@nixbitcoin
Copy link
Member

Should this be included in https://github.com/fort-nix/nix-bitcoin/milestone/2?

@jonasnick
Copy link
Member Author

Do you mean refactoring the modules? I don't think so, because it's not user visible.

@nixbitcoin
Copy link
Member

Has this been taken care of through @erikarvstedt's various refactorings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Mid Term
Projects
None yet
Development

No branches or pull requests

2 participants