Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Save" modal #474

Open
ClementBeal opened this issue Oct 5, 2024 · 8 comments
Open

Remove the "Save" modal #474

ClementBeal opened this issue Oct 5, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@ClementBeal
Copy link
Contributor

Hi!

First, thank you for this project! It's very good and it works very well! I'll keep using it.

There's something that it's a bit annoying. Every time I press the "save" button to save my variable or my requests. a modal appears with a little animation. It's pretty the first time but when you add a lot of new endpoints or variables, you waste 1s each time.

Could it be possible to use a different kind of modal? Maybe a toast at the top right corner. In my opinion, it would be enough.

Btw, I use the last version from the main branch.

@ashitaprasad
Copy link
Member

Thanks for your feedback .. actually we are looking into deprecating the "Save" feature and autosaving when the user makes any new modification.
This issue is open for PRs for it as well.
Thanks!

@ashitaprasad ashitaprasad added the enhancement New feature or request label Oct 5, 2024
@mohit-nagaraj
Copy link

Hey i thought to give this a try. I have a idea to directly link the yes button action to save button instead of opening a pop up

@mohit-nagaraj
Copy link

Hey could you give more detail n point out where this is happening? why is tht only coming up when closing , cud u send some screeen shots

@ClementBeal
Copy link
Contributor Author

?

I don't understand your question

@ashitaprasad
Copy link
Member

@mohit-nagaraj Please focus on the other issue first. This issue has higher complexity and is "not a good first issue"

@AffanShaikhsurab
Copy link
Contributor

what about something like this
image

@AffanShaikhsurab
Copy link
Contributor

@ClementBeal is this something you were looking for ?

AffanShaikhsurab added a commit to AffanShaikhsurab/apidash that referenced this issue Jan 17, 2025
Replaced the modal that appears after pressing the "Save" button with a non-intrusive toast notification in the top-right corner. This improves the user experience by reducing interruptions, especially when saving multiple endpoints or variables in quick succession.

Closes foss42#474
@AffanShaikhsurab
Copy link
Contributor

we can work on the ui part of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@ashitaprasad @ClementBeal @AffanShaikhsurab @mohit-nagaraj and others