-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support asynchronous methods in ICacheStore
#16
Comments
Sorry, I need to figure out my GitHub notifications. Could we avoid making this many changes by adding an export interface IAsyncCacheStore {
get(key: string): Promise<string | null>;
set(key: string, value: string): Promise<void>;
remove(key: string): Promise<void>;
} |
@fostertheweb we could create a separate Since I made the functions in If we create a separate |
Ah yeah for whatever reason I was thinking you created a fully custom caching strategy, instead of extending |
Solved with #18 |
@therealsujitk Version |
@fostertheweb Thankyou! |
It would be great if asynchronous methods were supported in
ICacheStore
for when developers need to implement custom caching that cannot be called synchronously.@fostertheweb it would be great if you could review & test this PR and merge it to this fork if you think everything looks good. Thanks!
The text was updated successfully, but these errors were encountered: