Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: incorrect link in solmate example #1183

Closed
letmejustputthishere opened this issue Apr 22, 2024 · 1 comment · Fixed by #1297
Closed

bug: incorrect link in solmate example #1183

letmejustputthishere opened this issue Apr 22, 2024 · 1 comment · Fixed by #1297
Labels
good first issue Good for newcomers T-to-fix Type: issue in docs

Comments

@letmejustputthishere
Copy link
Contributor

the url here doesn't really help me figure out how to provide a URL to the constructor at deployment
@zerosnacks
Copy link
Member

Should be updated to https://docs.opensea.io/docs/deploying-a-seadrop-compatible-contract

@zerosnacks zerosnacks added good first issue Good for newcomers T-to-fix Type: issue in docs labels Sep 13, 2024
@zerosnacks zerosnacks changed the title wrong link in solmate example? bug: incorrect link in solmate example Sep 13, 2024
@zerosnacks zerosnacks mentioned this issue Sep 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Book Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers T-to-fix Type: issue in docs
Projects
No open projects
Foundry Book
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect link in solmate example foundry-rs/book
2 participants
@letmejustputthishere @zerosnacks