Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pydantic model for cellpose channel input? #412

Closed
jluethi opened this issue Jun 8, 2023 · 1 comment · Fixed by #422
Closed

Add Pydantic model for cellpose channel input? #412

jluethi opened this issue Jun 8, 2023 · 1 comment · Fixed by #422
Labels
High Priority Current Priorities & Blocking Issues JSON Schemas

Comments

@jluethi
Copy link
Collaborator

jluethi commented Jun 8, 2023

The review of input arguments & the discussions on pydantic models for napari workflows (e.g. #404) and channel (#386 (comment)) made me think:

We should also refactor the way we handle the channel inputs in Cellpose.

Currently, we do:

wavelength_id: Optional[str] = None,
channel_label: Optional[str] = None,
wavelength_id_c2: Optional[str] = None,
channel_label_c2: Optional[str] = None,

But actually, this is very similar to the input specs of napari workflows, just with slightly different limits: we can only use "image" as type and only have up to 2 images, where order matters

=> let's see whether we can use a variant of what we build for napari workflows input & output arguments here as well!

@jluethi jluethi added the High Priority Current Priorities & Blocking Issues label Jun 8, 2023
tcompa added a commit that referenced this issue Jun 12, 2023
@tcompa tcompa linked a pull request Jun 12, 2023 that will close this issue
@tcompa tcompa changed the title Refactoring cellpose channel input Add Pydantic model for cellpose channel input? Jun 12, 2023
@tcompa
Copy link
Collaborator

tcompa commented Jun 15, 2023

Ref #404 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Current Priorities & Blocking Issues JSON Schemas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants