fix: Autocomplete multiselect #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combox's default comparison is not working as expected, so providing users to override this comparison according to there needs.
|
@safwansamsudeen Can you please check this |
|
@netchampfaris should we add a default function as well for this instead of user explicitly passing the comparison function. What are your thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combox's default comparison is not working as expected, so providing users to override this comparison according to there needs.
In this commit I've updated the code for autocomplete story with Multiple options & Search to provide the example of overriding the combox's by function.
Fixes: #263