Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DropdownFeatherIcon for consistent look. #267

Open
maharshivpatel opened this issue Feb 20, 2025 · 1 comment
Open

add DropdownFeatherIcon for consistent look. #267

maharshivpatel opened this issue Feb 20, 2025 · 1 comment

Comments

@maharshivpatel
Copy link

When we provide icon string in <Dropdown /> like below.

<Dropdown
	:options="[
		{
			group: 'Print Designer',
			hideLabel: true,
			items: [
				{
					...
					icon: 'plus',
				},
			],
		},
	]"
/>

It uses <FeatherIcon /> with some classes here.
however, when we want to create sub-menu by passing component like this one in builder

we need to copy mr-2 h-4 w-4 flex-shrink-0 text-ink-gray-6 in component where we use <FeatherIcon /> for consistent look. also, there is possibility that if/when classes are changed in frappe-ui there will be inconstancies.

proposed solution: have <DropdownFeatherIcon /> that can be used in components for consistent look

@maharshivpatel
Copy link
Author

@netchampfaris thoughts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant