ERPNext V15 - Error While Rename Item Code #40

donnieferdian · 2023-12-07T05:28:11Z

Information about bug

Hi Guys, i've got Error while Rename item Code

Screen.Recording.2023-12-07.at.13.12.42.mov

Details

App Versions

{
	"erpnext": "15.5.0",
	"frappe": "15.4.1",
	"hrms": "15.5.0",
	"payments": "0.0.1",
	"print_designer": "1.0.0",
	"webshop": "0.0.1"
}

Route

Form/Item/LOSTVAPE - URSA BABY KIT

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 110, in application
    response = frappe.api.handle(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
           ^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/__init__.py", line 1715, in call
    return fn(*args, **newargs)
           ^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/rename_doc.py", line 75, in update_document_title
    transformed_name = doc.run_method("before_rename", current_name, updated_name, merge)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 950, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1316, in composer
    return composed(self, method, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1300, in runner
    add_to_return_value(self, f(self, method, *args, **kwargs))
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: execute() takes from 3 to 4 positional arguments but 5 were given

Request Data

{
	"type": "POST",
	"args": {
		"doctype": "Item",
		"docname": "LOSTVAPE - URSA BABY KIT",
		"name": "URSA BABY KIT",
		"title": "URSA BABY KIT",
		"enqueue": true,
		"merge": 0,
		"freeze": true,
		"freeze_message": "Updating related fields..."
	},
	"freeze": true,
	"freeze_message": "Updating related fields...",
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/frappe.model.rename_doc.update_document_title",
	"request_id": null
}

Response Data

{
	"exception": "TypeError: execute() takes from 3 to 4 positional arguments but 5 were given",
	"exc_type": "TypeError"
}

Module

stock

Version

Erpnext : 15.5.0
Frappe : 15.4.1

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

### App Versions

{
	"erpnext": "15.5.0",
	"frappe": "15.4.1",
	"hrms": "15.5.0",
	"payments": "0.0.1",
	"print_designer": "1.0.0",
	"webshop": "0.0.1"
}

Route

Form/Item/LOSTVAPE - URSA BABY KIT

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 110, in application
    response = frappe.api.handle(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/__init__.py", line 49, in handle
    data = endpoint(**arguments)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/api/v1.py", line 36, in handle_rpc_call
    return frappe.handler.handle()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 49, in handle
    data = execute_cmd(cmd)
           ^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/__init__.py", line 1715, in call
    return fn(*args, **newargs)
           ^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/utils/typing_validations.py", line 31, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/rename_doc.py", line 75, in update_document_title
    transformed_name = doc.run_method("before_rename", current_name, updated_name, merge)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 950, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1316, in composer
    return composed(self, method, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1300, in runner
    add_to_return_value(self, f(self, method, *args, **kwargs))
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: execute() takes from 3 to 4 positional arguments but 5 were given

Request Data

{
	"type": "POST",
	"args": {
		"doctype": "Item",
		"docname": "LOSTVAPE - URSA BABY KIT",
		"name": "URSA BABY KIT",
		"title": "URSA BABY KIT",
		"enqueue": true,
		"merge": 0,
		"freeze": true,
		"freeze_message": "Updating related fields..."
	},
	"freeze": true,
	"freeze_message": "Updating related fields...",
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/frappe.model.rename_doc.update_document_title",
	"request_id": null
}

Response Data

{
	"exception": "TypeError: execute() takes from 3 to 4 positional arguments but 5 were given",
	"exc_type": "TypeError"
}

The text was updated successfully, but these errors were encountered:

donnieferdian · 2024-01-04T17:08:58Z

Update to the latest version of webshop, the issue has been fixed: fe42033

hi @sagarvora
I have updated to the latest version, and the error notification no longer appears. However, the error message is now displayed in the comments section.

Meanwhile, the product code still cannot be updated. I have attached a video demonstrating the issue.
https://youtu.be/6mcGUFvJL_w
Best regards.

davygarg · 2024-01-05T05:47:04Z

Update to the latest version of webshop, the issue has been fixed: fe42033

hi @sagarvora I have updated to the latest version, and the error notification no longer appears. However, the error message is now displayed in the comments section.

Meanwhile, the product code still cannot be updated. I have attached a video demonstrating the issue. https://youtu.be/6mcGUFvJL_w Best regards.

Hi@sagarvora

I also have same issue.

Traceback (most recent call last):
File "apps/frappe/frappe/model/document.py", line 1631, in execute_action
getattr(doc, __action)(**kwargs)
File "apps/frappe/frappe/model/document.py", line 1035, in _rename
self.name = rename_doc(doc=self, new=name, merge=merge, force=force, validate=validate_rename)
File "apps/frappe/frappe/model/rename_doc.py", line 208, in rename_doc
new_doc.run_method("after_rename", old, new, merge)
File "apps/frappe/frappe/model/document.py", line 953, in run_method
out = Document.hook(fn)(self, *args, **kwargs)
File "apps/frappe/frappe/model/document.py", line 1319, in composer
return composed(self, method, *args, **kwargs)
File "apps/frappe/frappe/model/document.py", line 1303, in runner
add_to_return_value(self, f(self, method, *args, **kwargs))
TypeError: execute() takes from 1 to 2 positional arguments but 5 were given

Regards

sagarvora · 2024-01-05T08:37:03Z

will fix soon with PR

donnieferdian · 2024-01-08T11:02:39Z

Solve #50
thankyou @sagarvora

donnieferdian added the bug Something isn't working label Dec 7, 2023

donnieferdian changed the title ~~Error Rename Item Code~~ ERPNext V15 - Error While Rename Item Code Dec 7, 2023

s-aga-r transferred this issue from frappe/erpnext Dec 8, 2023

ankush transferred this issue from frappe/frappe Dec 11, 2023

This comment was marked as outdated.

Sign in to view

sagarvora mentioned this issue Jan 4, 2024

Unable to rename Item Code frappe/erpnext#38721

Closed

sagarvora mentioned this issue Jan 7, 2024

fix: ensure all arguments passed to after_rename hook are accepted #50

Merged

ankush closed this as completed in #50 Jan 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ERPNext V15 - Error While Rename Item Code #40

ERPNext V15 - Error While Rename Item Code #40

donnieferdian commented Dec 7, 2023 •

edited

Loading

App Versions

Route

Traceback

Request Data

Response Data

This comment was marked as outdated.

donnieferdian commented Jan 4, 2024

davygarg commented Jan 5, 2024

sagarvora commented Jan 5, 2024

donnieferdian commented Jan 8, 2024

ERPNext V15 - Error While Rename Item Code #40

ERPNext V15 - Error While Rename Item Code #40

Comments

donnieferdian commented Dec 7, 2023 • edited Loading

Information about bug

App Versions

Route

Traceback

Request Data

Response Data

Module

Version

Installation method

Relevant log output / Stack trace / Full Error Message.

Route

Traceback

Request Data

Response Data

This comment was marked as outdated.

donnieferdian commented Jan 4, 2024

davygarg commented Jan 5, 2024

sagarvora commented Jan 5, 2024

donnieferdian commented Jan 8, 2024

donnieferdian commented Dec 7, 2023 •

edited

Loading