Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Ability to filter event/events #1211

Closed
Sboonny opened this issue Jul 12, 2022 · 3 comments
Closed

Ability to filter event/events #1211

Sboonny opened this issue Jul 12, 2022 · 3 comments
Assignees
Labels
UI/UX This issue deals with UI/UX

Comments

@Sboonny
Copy link
Member

Sboonny commented Jul 12, 2022

Discuss your ideas or share your views:

Make sure to tell how your idea will benefit this project.

I want to create the ability to filter our data with input from the users, I am started with event/events because it seems the easiest.

Here is the prototype of how it looks.

image

While creating the interactivity, I realized there are multiple ways to go about this.

So first, Is this something that is needed?

if yes

  • is the filter option remembered after the session ended?
  • Does the filter option hide the data or change how the data being request?
  • I am sure you guys have more questions or inputs that will polish this function
@allella
Copy link
Contributor

allella commented Jul 12, 2022

There is a filter option on the events page in an early mockup, but I don't believe we've had an issue for the filtering, MVP or otherwise.

There is a conversation about adding an event search bar, but that's also been put on the Roadmap and I'd suggested that location filter is probably the most important filter and that may still be the case since freeCodeCamp is likely to host an instance for beta testing with events in various cities.

I feel like the search feature is still not and MVP issue. Though, there may be a case for 1 or two filters, like the location, but the fCC staff like @ojeytonwilliams and @nhcarrigan may have a better feel for the scope of the fCC testing and if filters are needed for MVP.

One other note is that we've talked a bit about UI elements, like switches vs checkboxes, and Cecilia linked to this switch vs checkbox comparison. This in the context of Accessibility as well, which we may want to have someone look, like @ceciliaconsta3 , around and pick out any major accessibility issues before the MVP goes live.

@Sboonny
Copy link
Member Author

Sboonny commented Jul 12, 2022

but I don't believe we've had an issue for the filtering, MVP or otherwise.

True, I am trying to create a function similar to what Quincy mentioned in his comment in issue 274, without holding the issue hostage like how I did in issue #276 , stopping people who see my pull request from opening pr and not fixing the issue.

And I think filtering the events depending on user interest in them, will create a similar function. Although I may be wrong and I am wasting time.😅

There is a filter option on the events page in an early mockup,

Thank you🤍, I will use it moving forward.

About the UI and SEO concerns, I will be honest. I was lazy because that wasn't my original goal, but after reading your comment, with that amount of info, I can't help but give them extra care 👍

@Sboonny Sboonny self-assigned this Jul 20, 2022
@Sboonny Sboonny added the UI/UX This issue deals with UI/UX label Jul 20, 2022
@Sboonny
Copy link
Member Author

Sboonny commented Jan 12, 2023

closed in favor of #2188

@Sboonny Sboonny closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UI/UX This issue deals with UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants