Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the colloc tag #22

Closed
humenda opened this issue Jun 28, 2017 · 4 comments
Closed

Add support for the colloc tag #22

humenda opened this issue Jun 28, 2017 · 4 comments

Comments

@humenda
Copy link
Member

humenda commented Jun 28, 2017

At the moment, the colloc tag is not supported by the style sheets. It seems as if it were already present as an attribute, though.
I could have a look at the weekend at changing the style sheets, but would be happy if a XSL expert would have time for this little task.

Ah yes, justification: dan-eng :)

@fceschmidt
Copy link
Member

For a short example, the following TEI entry

         <entry>
            <form>
               <orth>deltage</orth>
            </form>
            <gramGrp>
                <pos>v</pos>
                <colloc>i</colloc>
            </gramGrp>
            <sense>
               <cit type="trans">
                  <quote>participate</quote>
                  <gramGrp>
                      <pos>v</pos>
                      <colloc>in</colloc>
                  </gramGrp>
               </cit>
               <cit type="trans">
                  <quote>take part</quote>
                  <gramGrp>
                      <pos>v</pos>
                      <colloc>in</colloc>
                  </gramGrp>
               </cit>
               <cit type="example">
                   <quote>Vi deltager i konkurrencen.</quote>
                   <cit type="translation">
                       <quote>We take part in the competition.</quote>
                   </cit>
               </cit>
            </sense>
         </entry>

generates this DICT entry:

deltage <v>
participate <v>, take part <v>
      "Vi deltager i konkurrencen."  - We take part in the competition.

If possible, I would prefer to have something like the following instead:

deltage (i) <v>
participate (in) <v>, take part (in) <v>
      "Vi deltager i konkurrencen."  - We take part in the competition.

By the way I've also thought about using something like <usg type="gram">participate in sth.</usg> for this, and frankly I don't know what would be considered more correct.

@fceschmidt
Copy link
Member

Also I just found out that a gramGrp with only ignored element inside, such as:

<gramGrp>
    <colloc>in</colloc>
</gramGrp>

produces empty angle brackets, like:

<>

@humenda
Copy link
Member Author

humenda commented Jun 29, 2017 via email

@humenda humenda closed this as completed in 7dcdbaf Jul 1, 2017
@fceschmidt
Copy link
Member

I added a comment to line 122 of the commit 7dcdbaf. It's just about the selector in the xsl:value-of clause, which I found to be quite easy to fix, so please consider correcting this. I appreciate your dedication!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants