update installation instructions for Ubuntu Noble itself #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathandyer
previously approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Thank you @cfm, this is looking great! It's nice to see so much content that's no longer relevant being removed.
Just to note, I stepped through the download/verification portion fully. I was able to grab the Ubuntu signing key via hkps, and verified the signature and checksum for the iso.
One small comment that's up for debate, otherwise LGTM
We also remove all instructions pertaining to backing up and restoring SecureDrops with v2 onion services, since these are long gone.
cfm
force-pushed
the
637-noble-itself
branch
from
c52a5e3 to
86acd0f
Compare
nathandyer
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Thanks @cfm, with the additional change this all LGTM
Going to approve, but leave open just a bit longer in case anyone else would like to review prior to merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Testing
Visual review should be sufficient, except for:
create_usb_boot_drives.rstto check for typos and copypasta.securedrop-docs/docs/admin/installation/create_usb_boot_drives.rst
Lines 165 to 167 in c52a5e3
hkpsfor me).Release
Well accounted for in freedomofpress/securedrop#7444.
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000