Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build release in Dockerfile #84

Open
ghost opened this issue Sep 3, 2020 · 3 comments
Open

Build release in Dockerfile #84

ghost opened this issue Sep 3, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Sep 3, 2020

I had a look at the Dockerfile and I suggest using mix release instead of copying everything and building.
I can do it, tell me if that's interesting you.

I also suggest publishing a version to hub.docker.com for ARM and x86.

@rupurt
Copy link
Contributor

rupurt commented Sep 4, 2020

Heyo @steffenix 👋

The current docker + compose setup is targeted at development but I think it's a good call to have a prod one also and use mix release. Do you mind creating a PR?

What's your thoughts on:

  • Rename the current Dockerfile to Dockerfile.dev
  • Create a new Dockerfile the builds the app with mix release
  • Use Dockerfile.dev in the build context of docker-compose.override.yml
  • Use Dockerfile in the base docker-compose.yml

@rupurt
Copy link
Contributor

rupurt commented Nov 15, 2020

@steffenix I made some improvements to the docker setup in e5894cd

The second layer could now build using mix release

@ghost
Copy link
Author

ghost commented Nov 16, 2020

I have put this on pause but I have pushed and opened a PR it's WIP, I have some issues with the JS assets.

#169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant