We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageCaptionSpace handles edge cases correctly and does not throw error
ImageCaptionSpace
Function ImageCaptionSpace assumes that element returned by selection.element() always has at least 2 parents:
selection.element()
... function ImageCaptionSpace(sel_el, e) { // https://github.com/froala-labs/froala-editor-js-2/issues/4429 var _ref = sel_el && sel_el.parentElement, parentElement = _ref.parentElement; ...
which is not always correct and should be corrected to avoid exceptions. For example this way:
... parentElement = _ref?.parentElement; ...
4.2.1
Any
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Expected behavior.
ImageCaptionSpace
handles edge cases correctly and does not throw errorActual behavior.
Function
ImageCaptionSpace
assumes that element returned byselection.element()
always has at least 2 parents:which is not always correct and should be corrected to avoid exceptions. For example this way:
Editor version.
4.2.1
OS.
Any
Browser.
Any
The text was updated successfully, but these errors were encountered: