Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua error while doing pet battles #339

Closed
frozn opened this issue Aug 26, 2024 · 1 comment
Closed

lua error while doing pet battles #339

frozn opened this issue Aug 26, 2024 · 1 comment
Labels
1_bug Something isn't working 2_to develop Development can begin 3_solved Issue is fixed

Comments

@frozn
Copy link
Owner

frozn commented Aug 26, 2024

Describe the bug

From: ImmortalMotion

Got the following error while doing pet battles with the 26/08 release,

[17:10] Interface/AddOns/TipTacItemRef/ttItemRef.lua:3060: bad argument #1 to 'GetItemQualityColor' (outside of expected range 0 to 4294967295 - Usage: local r, g, b, qualityString = C_Item.GetItemQualityColor(quality))
[17:10] [string "=[C]"]: in function `GetItemQualityColor'
[string "@Interface/AddOns/TipTacItemRef/ttItemRef.lua"]:3060: in function `battlepet'
[string "@Interface/AddOns/TipTacItemRef/ttItemRef.lua"]:1165: in function <Interface/AddOns/TipTacItemRef/ttItemRef.lua:1161>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `BattlePetToolTip_Show'
[string "@Interface/AddOns/Blizzard_FrameXML/BattlePetTooltip.lua"]:19: in function `BattlePetToolTip_ShowLink'
[string "@Interface/AddOns/Prat-3.0-3.9.58/modules/HoverTips.lua"]:224: in function `?'
[string "@Interface/AddOns/Bartender4/libs/AceHook-3.0-9/AceHook-3.0.lua"]:90: in function <...e/AddOns/Bartender4/libs/AceHook-3.0/AceHook-3.0.lua:87>
[string "=[C]"]: ?
[17:10] (*temporary) = -1
(*temporary) = "outside of expected range 0 to 4294967295 - Usage: local r, g, b, qualityString = C_Item.GetItemQualityColor(quality)"

Source: https://legacy.curseforge.com/wow/addons/tiptac-reborn?comment=590

Steps to Reproduce

No response

Expected behavior

No response

Additional context

No response

Version of TipTac Reborn

24.08.26

Flavor/Version of WoW

Unknown

@frozn frozn added the 1_bug Something isn't working label Aug 26, 2024
@frozn
Copy link
Owner Author

frozn commented Aug 26, 2024

Fixed lua error during applying quality border if quality is invalid, e.g. from invalid chat links.

Will be included in the next release.

@frozn frozn added 2_to develop Development can begin 3_solved Issue is fixed labels Aug 26, 2024
@frozn frozn closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_bug Something isn't working 2_to develop Development can begin 3_solved Issue is fixed
Projects
None yet
Development

No branches or pull requests

2 participants
@frozn and others