Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket.dependencies: Allow Paket.Core to be in pre-release version to get the integration-tests pass. #2791

Merged
merged 3 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ source https://api.nuget.org/v3/index.json
source https://ci.appveyor.com/nuget/fake

nuget Fake.Runtime prerelease
nuget FSharp.Core prerelease
nuget FSharp.Core prerelease
nuget Paket.Core prerelease
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ storage: none
source https://api.nuget.org/v3/index.json
source ../../../release/dotnetcore
nuget Fake.Runtime prerelease
nuget FSharp.Core prerelease"
nuget FSharp.Core prerelease
nuget Paket.Core prerelease"

open Fake.Runtime

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ storage: none
source https://api.nuget.org/v3/index.json
source ../../../release/dotnetcore
nuget Fake.Runtime prerelease
nuget FSharp.Core prerelease"
nuget FSharp.Core prerelease
nuget Paket.Core prerelease"

open Fake.Runtime

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ source ../../../release/dotnetcore

nuget Fake.Core.Target prerelease
nuget System.Reactive.Compatibility
nuget FSharp.Core prerelease"
nuget FSharp.Core prerelease
nuget Paket.Core prerelease"
#endif

printfn "before load"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ source ../../../release/dotnetcore
//source https://ci.appveyor.com/nuget/paket

nuget Fake.Runtime prerelease
nuget FSharp.Core prerelease"
nuget FSharp.Core prerelease
nuget Paket.Core prerelease"
#endif
#load ".fake/reference_fake-runtime.fsx/intellisense.fsx"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ source ../../../release/dotnetcore
//source https://ci.appveyor.com/nuget/paket

nuget Fake.Runtime prerelease
nuget FSharp.Core prerelease"
nuget FSharp.Core prerelease
nuget Paket.Core prerelease"
#endif
open klajsdhgfasjkhd

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#r "paket: //source https://ci.appveyor.com/nuget/paket"
#r "paket: nuget Fake.Runtime prerelease"
#r "paket: nuget FSharp.Core prerelease"
#r "paket: nuget Paket.Core prerelease"
#endif

// Issue https://github.com/fsharp/FAKE/issues/2121
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ source ../../../release/dotnetcore

nuget Fake.Runtime prerelease
nuget FSharp.Core prerelease
nuget Microsoft.NETCore.App
nuget Microsoft.NETCore.App
nuget Paket.Core prerelease
2 changes: 1 addition & 1 deletion paket.dependencies
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ group fakemodule
nuget FParsec
nuget Octokit
nuget Newtonsoft.Json
nuget Paket.Core 8.1.0-alpha004
nuget Paket.Core prerelease
nuget NuGet.Protocol
nuget NuGet.Packaging
nuget Mono.Cecil prerelease
Expand Down
6 changes: 3 additions & 3 deletions src/test/Fake.Core.IntegrationTests/SimpleHelloWorldTests.fs
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ let tests =
"Expected correct declaration of 'Start'"
{ Declaration.Empty with
File = scriptFile
Line = 36 }
Line = 37 }
startTarget.Declaration

Expect.equal "Expected correct hard dependencies of 'Start'" [] startTarget.HardDependencies
Expand All @@ -261,7 +261,7 @@ let tests =
"Expected correct declaration of 'TestTarget'"
{ Declaration.Empty with
File = scriptFile
Line = 38 }
Line = 39 }
testTarget.Declaration

Expect.equal
Expand All @@ -270,7 +270,7 @@ let tests =
Declaration =
{ Declaration.Empty with
File = scriptFile
Line = 45 } } ]
Line = 46 } } ]
testTarget.HardDependencies

Expect.equal "Expected correct description of 'TestTarget'" "" testTarget.Description
Expand Down
8 changes: 5 additions & 3 deletions src/test/Fake.Core.UnitTests/Fake.DotNet.MSBuild.fs
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,18 @@ open Expecto

[<Tests>]
let tests =
let flagsTestCase name changeBuildArgs expected =
let flagsTestCase name changeBuildArgs (expected: string) =
testCase name
<| fun _ ->
let _, cmdLine = MSBuild.buildArgs changeBuildArgs

let expected =
let trimmed = expected.Trim()

if BuildServer.ansiColorSupport then
$"%s{expected} /clp:ForceConsoleColor".Trim()
$"%s{trimmed} /clp:ForceConsoleColor".Trim()
else
expected.Trim()
trimmed

let expected = $"/m /nodeReuse:False {expected} /p:RestorePackages=False".Trim()

Expand Down
Loading