Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldBank provider is broken (their API changed to https) #1514

Closed
pkese opened this issue Sep 25, 2024 · 4 comments
Closed

WorldBank provider is broken (their API changed to https) #1514

pkese opened this issue Sep 25, 2024 · 4 comments

Comments

@pkese
Copy link
Contributor

pkese commented Sep 25, 2024

WorldBank stopped responding to http requests, but is responding to https.

let defaultServiceUrl = "http://api.worldbank.org/v2"

The above url needs to change to https.

@pkese
Copy link
Contributor Author

pkese commented Sep 25, 2024

@Thorium
Copy link
Member

Thorium commented Sep 27, 2024

Yes, the current build fails without this.

@pkese
Copy link
Contributor Author

pkese commented Oct 1, 2024

@dsyme @cartermp any chance of pulling either #1515 or #1516 and making a new release?

We have an issue:

  • any code using WorldbankProvider stoped working
  • any project using WorldbankProvider stopped compiling
  • any code using WorldbankProvider has broken language server based editor tools.

@dsyme dsyme closed this as completed in 07fb089 Oct 2, 2024
dsyme added a commit that referenced this issue Oct 2, 2024
Change WorldBank url to https; fixes #1514
@dsyme
Copy link
Contributor

dsyme commented Oct 2, 2024

@pkese @Thorium For a new release please bump the release notes, and we can crank the handle (it should basically be automatic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants