Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker::connect_with_transport #458

Closed
izissise opened this issue Aug 27, 2024 · 3 comments
Closed

Docker::connect_with_transport #458

izissise opened this issue Aug 27, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@izissise
Copy link
Contributor

izissise commented Aug 27, 2024

Hello,

I'd like to connect to a docker daemon with tls certificate, but the certificate are never stored on the filesystem client side.
connect_with_ssl only take Path for keys.

Would it be possible to have a constructor that take directly a Transport so a user can set it up themselve.
An alternative would be to able to pass a rustls::ClientConfig.

I'm willing to contribute this, what do you think?

Thanks,
Hugues

Edit: I think this could also make it possible to tunnel through ssh #244

@fussybeaver
Copy link
Owner

Yes, I'm definitely interested. There was some conversation recently around request customisation ( #395 (comment) and #436 ), so it would be interesting to see if this implementation can be used as a template to solve that problem too.

@fussybeaver
Copy link
Owner

@izissise can we close this, due to #459 ?

@izissise
Copy link
Contributor Author

izissise commented Sep 9, 2024

Yes all good for me :)

@izissise izissise closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants