Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High V_Scale values don't render as expected #29

Open
Yazwh0 opened this issue Nov 8, 2022 · 1 comment
Open

High V_Scale values don't render as expected #29

Yazwh0 opened this issue Nov 8, 2022 · 1 comment

Comments

@Yazwh0
Copy link

Yazwh0 commented Nov 8, 2022

With a high V_Scale value we get what appears to be line 480 copied down the screen. This feels unintuitive. It should either be line 479 (where line 0 is the first line), draw nothing, or should continue to render without the 480 constraint.

So either change this to 479, or remove the check?
https://github.com/fvdhoef/vera-module/blob/rev4/fpga/source/graphics/composer.v#L157

image

Test app for above:
code: test.zip
prg: example.zip

@Yazwh0
Copy link
Author

Yazwh0 commented Nov 8, 2022

scaled_y_counter isn't wide enough to hold the max scaled value of 956. (0xff * 480 >> 7) If that cannot be widened I guess second most preferable result would be that it would work like high H_Scale values where it renders colour 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant