Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBlank IRQ generation is missing every odd frames in interlaced modes #7

Open
akumanatt opened this issue Apr 2, 2022 · 1 comment

Comments

@akumanatt
Copy link
Contributor

As seen here, the signal should be generated on both even frames and odd frames, giving ~60Hz rate:

assign vblank_pulse = h_last && (vcnt == 524 || vcnt == 1049);

However, since vcnt counts twice per line, h_last is only true when vcnt is odd. This can be fixed by replacing h_last with h_half_line_last just like in the field toggling logic.

Here is a measurement confirming the bug:
image

@jburks
Copy link
Contributor

jburks commented Apr 3, 2022

A brief clarification of the trace above. The yellow "VSYN" signal was obtained with the probe on the HSYNC pin. It is the composite sync signal and should have just been labeled "SYNC".

jburks added a commit to jburks/vera-module that referenced this issue Sep 25, 2022
jburks pushed a commit to jburks/vera-module that referenced this issue Jul 24, 2023
akumanatt added a commit to akumanatt/vera-module that referenced this issue Nov 4, 2023
* refactored video modulator to use 1 less DSP and lessening the timing pressure for inputs of y_s, i_s and q_s flip flops

* added module for a pair of 8x8 unsigned multipliers

* rename of wires to make it more clear and explicit

* small cleanup

* small cleanup

* changed version number to v0.1.2

* Gave negated signals a suffix to indicate they contain the negated value of their intended value

* LUT usage reduction by refactoring and reordering

* moved address and data related logic to separate addr_data module

* LUT usage reduction by refactoring and reordering (fvdhoef#5)

* Revert: Increase audio mixing resolution (fvdhoef#7)

Co-authored-by: Natt Akuma <[email protected]>

* FX: Separate address and data logic into module (fvdhoef#8)

* LUT usage reduction by refactoring and reordering

* moved address and data related logic to separate addr_data module

* replaced another two multiplications with adders

* replaced address logic structure with extendable one, added (dummy) addr1-mode

* FX extendable structure for address logic (fvdhoef#9)

* LUT usage reduction by refactoring and reordering

* moved address and data related logic to separate addr_data module

* replaced another two multiplications with adders

* replaced address logic structure with extendable one, added (dummy) addr1-mode

* added 8bpp line draw mode

* replaced tabs by spaces

* changed naming and added comments

* [FX] Line draw mode (8bpp) (fvdhoef#10)

* LUT usage reduction by refactoring and reordering

* moved address and data related logic to separate addr_data module

* replaced another two multiplications with adders

* replaced address logic structure with extendable one, added (dummy) addr1-mode

* added 8bpp line draw mode

* replaced tabs by spaces

* changed naming and added comments

* added polygon filler helper (8bpp)

* typo and more explicit check if ADDR0/1 is untouched

* [FX] Polygon filler mode (8bpp) (fvdhoef#12)

* LUT usage reduction by refactoring and reordering

* moved address and data related logic to separate addr_data module

* replaced another two multiplications with adders

* replaced address logic structure with extendable one, added (dummy) addr1-mode

* added 8bpp line draw mode

* replaced tabs by spaces

* changed naming and added comments

* added polygon filler helper (8bpp)

* typo and more explicit check if ADDR0/1 is untouched

* added affine mode (8bpp)

* added 32-bit cache and multiplier/accumulator, including transparent writes and 16bit hop mode

* added 4-bit and 2-bit modes

* Bump version (fvdhoef#17)

* Bump version

* Set version to 0.3.1

---------

Co-authored-by: Jeffrey <[email protected]>
Co-authored-by: Joe Burks <[email protected]>
Co-authored-by: Natt Akuma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants