Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore binaries #40

Open
Halkcyon opened this issue Feb 14, 2020 · 5 comments
Open

gitignore binaries #40

Halkcyon opened this issue Feb 14, 2020 · 5 comments

Comments

@Halkcyon
Copy link

Assuming you have .NET Core installed, you can generate one of these with dotnet new gitignore. You can create a release by specifying a tag and dropping the binaries in through the web page so versioning and such can also be more manageable.

@Halkcyon Halkcyon changed the title ignore binaries gitignore binaries Feb 14, 2020
@Halkcyon
Copy link
Author

Halkcyon commented Feb 14, 2020

Side-note: I've been porting the codebase over to .NET Core so it doesn't have the Framework dependency (compile to a single exe) and we could take advantage of newer features and standard library APIs

@igotinfected
Copy link

There is already a .NET Core PR in progress #28

@JackRhodes
Copy link

@TheIncorrigible1 feel free to put up a PR and I can close my one if you have progressed further.

I had a play with the single exe and it worked, however for some reason it was not generating the .json file to disk therefore you couldn't adjust settings such as the auto update flag etc. I only spent an hour or so looking at it so there's probably a way to do so.

@Halkcyon
Copy link
Author

Halkcyon commented Feb 14, 2020

@JackRhodes I've got it working with the new System.Text.Json but I didn't get it compiling to single-exe w/ VS2019, just the cli so far, so I've gotta figure that out. I'll follow-on w/ a PR then

The auto-update logic should be looking at releases instead of source, so that requires some cooperation from the repo owner/collabs.

@sir-wilhelm
Copy link

sir-wilhelm commented Feb 15, 2020

I have auto updates working off releases on my repo.

https://github.com/sir-wilhelm/SmartHunter/tree/net-core-self-contained
I've been playing w/ the .net core and self-contained exe too, but saw the same issue @JackRhodes did with it not generating .json files to disk.
That would break disabling auto updates, and using custom .json files (in my version).

I also have not looked to see if the self contained version can handle custom XAML files for changing/customizing the skin.

I've been monitoring this repo too, so if you end up making a PR w/ the changes I might test/merge into my version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants