Use of React.Children.only() #48

AdamBoxall · 2017-10-11T11:00:06Z

Is the use of React.Children.only() necessary? It enforces more mark-up.

<DocumentTitle title="...">
  <div>
    <div>...</div>
    <div>...</div>
  </div>
</DocumentTitle>

Instead of just:

<DocumentTitle title="...">
  <div>...</div>
  <div>...</div>
</DocumentTitle>

Containers are no longer required in React v16, so it would be nice to avoid having them here, too.

The text was updated successfully, but these errors were encountered:

dvislov · 2017-11-17T10:59:56Z

👍

browniefed · 2017-12-20T18:54:51Z

For those that stumble upon this you can simple use the new Fragment from React.

import React { Fragment } from "react"

<DocumentTitle title="...">
  <Fragment>
    <div>...</div>
    <div>...</div>
  </Fragment>
</DocumentTitle>

serprex linked a pull request Feb 14, 2018 that will close this issue

Purely return props.children, allowing multiple children #53

Open

Provide feedback