Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for libtidy 5.6 #21

Open
jokester opened this issue Nov 6, 2017 · 7 comments
Open

Prepare for libtidy 5.6 #21

jokester opened this issue Nov 6, 2017 · 7 comments

Comments

@jokester
Copy link
Contributor

jokester commented Nov 6, 2017

@gagern Hello there. libtidy is targeting next 5.6 release to late November, so I made a branch in case we want to follow up. Will add more commits if I found necessary.

@jorrit
Copy link
Contributor

jorrit commented Nov 29, 2017

5.6.0 has been released. I am wondering if a new release of node-libtidy could be created?

See https://github.com/htacg/tidy-html5/tree/master.

@gagern
Copy link
Owner

gagern commented Dec 30, 2017

@jokester, feel free to turn that branch into a pull request. I'll have a look at it when I find the time. Hopefully this is a painless migration and opens the door for further improvements.

@adius
Copy link

adius commented Feb 17, 2018

Hey, what's the status on this?
Would be really cool to upgrade to 5.6.0! 😁

@prantlf
Copy link

prantlf commented Feb 25, 2018

@gagern, have a look at my PR #22, please. I based it on @jokester's work. I fixed some source files to continue working with tidy-html 5.6.0 in addition.

Names of option groups changed. See 5.4.0 and 5.6.0. It might be considered a breaking change.

@jokester
Copy link
Contributor Author

jokester commented Mar 1, 2018

Thanks @prantlf !!

@barhoumio
Copy link

Waiting @gagern merging your PR, here my npm that support node10 https://www.npmjs.com/package/node-libtidy

@cainrus
Copy link

cainrus commented Jul 16, 2018

Unable to build on my osx 10.13.4 machine:

➜ uname -a
Darwin mymachine.local 17.5.0 Darwin Kernel Version 17.5.0: Mon Mar  5 22:24:32 PST 2018; root:xnu-4570.51.1~1/RELEASE_X86_64 x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants