Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement branch:foo,bar #12

Open
gajus opened this issue Sep 29, 2022 · 3 comments
Open

Implement branch:foo,bar #12

gajus opened this issue Sep 29, 2022 · 3 comments
Labels
wontfix This will not be worked on

Comments

@gajus
Copy link
Owner

gajus commented Sep 29, 2022

name:foo,bar

should be equal to:

name:foo OR branch:bar
@gajus gajus added the enhancement New feature or request label Sep 29, 2022
@gajus
Copy link
Owner Author

gajus commented Sep 30, 2022

Implementing this most likely requires adding a new AST type that represents IN operation. Otherwise, we wouldn't be able to serialize AST back into the original query.

@gajus
Copy link
Owner Author

gajus commented Sep 30, 2022

We could also add support for an implicit OR operator, e.g. foo,bar equal to foo OR bar, but that becomes ambiguous in the context of name:foo,bar, i.e., does this mean name:foo OR branch:bar or name:foo OR bar

@gajus gajus added wontfix This will not be worked on and removed enhancement New feature or request labels Sep 30, 2022
@gajus
Copy link
Owner Author

gajus commented Sep 30, 2022

would name:foo,bar and name:foo, bar be treated differently?

Until there is clarity how to implement this in a way that does not cause ambiguity, it is unlikely to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant