-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HAWC 2HWC to gamma-cat? #150
Comments
First of all a general question: If the latter is the case, we should definitely add the hawc data for completeness, I think. The correspondence to existing sources may not be such an issue because the hawc collaboration listed the TeVCat counterparts in Table 2 Well, to add the data I would suggest to create one folder in input/data with the reference_id to the HAWC2 paper on arxiv, then, in that folder create tev-XXXXX.yaml files for every of the 39 sources. What do you think about these ideas? |
It's up for discussion. IMO we should focus on TeV and just prioritise our limited time to work on gamma-cat. Since 2HWC is little work to add, IMO it would be OK to add even if not very high priority. (but don't be fooled, it'll still take a day for you to code and a day to review for me at least, please don't start it before the PR in Gammapy is merged). I can look at / comment on your implementation solution for gamma-cat / 2HWC if / when someone has time to implement it, from a brief look it looks good (but I don't think the choice which source is which will be simple / we might need a new scheme to declare "sources" that aren't really independent and should not be included twice when creating the catalog. |
@cdeil For now I'm against adding data from TeV catalogs to gamma-cat, if those are available in machine readable format. What is the point of duplicating information that is already there just in a different format? I'm not sure if gamma-cat should have the goal to be a "complete" TeV or even GeV catalog (whatever that means...). I'd even go further and say gamma-cat isn't a catalog at all, I'd rather see it as a data collection and archive (the main difference being the uniformity in the analysis of sources...). For me, right now, gamma-cat provides access to data, that explicitly isn't available via (electronic) catalogs. This said, I would only continue to add information from individual source papers (of course including Fermi-LAT and HAWC publications...) and provide the possible associations with existing catalogs (such as HGPS and 2HWC) by source name, as suggested by @pdeiml. Those could also include several sources if the association is not unique. |
To be complete.
E.g. Gernot thinks it's very important to have that as the goal, and I mostly agree.
Gamma-cat has two goals and data products: data collection and catalog. @adonath - I think while maybe in theory there are differences in goals / scope in this discussion, in practice we're 100% agreed: we're manpower-limited and should focus on what's needed and prioritise (but take whatever useful contributions we get). So @pdeiml - if you don't care much what you work on, I would also prefer to not add 2HWC to gamma-cat now, but first to add other data to gamma-cat, or to add 2HWC to gamma-sky.net, if you want to learn some HTML / Typescript coding. |
I am divided in this and not very helpful for the discussion
I think this is essentially repeating what has been said above. If it is little work, let's add it. If it is more work, let's wait. |
I did get the HAWC 2HWC catalog in a nice clean format. They plan to add it to the HAWC website and make it publicly available soon also. Here's the reminder issue to add it to Gammapy and links to the 2HWC catalog: gammapy/gammapy#887 (comment)
My 2 cents: HAWC measurements are TeV and are in scope for gamma-cat. The arguments against adding it are: 2HWC is already in a machine-readable format; it's a fixed catalog; there will be several cases in the Galactic plan where it'll be hard to decide which 2HWC "source" corresponds to an existing gamma-cat "source" and when we should create a new gamma-cat "source".
Bottom line: I think we should add it. But I'm not sure, so @GernotMaier or anyone interested - thoughts?
The text was updated successfully, but these errors were encountered: