Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy python2 dependencies #2222

Closed
egede opened this issue Dec 7, 2023 · 3 comments
Closed

Remove legacy python2 dependencies #2222

egede opened this issue Dec 7, 2023 · 3 comments

Comments

@egede
Copy link
Member

egede commented Dec 7, 2023

In a few helper and template scripts we in fact still use python2. This should be updated

GangaCore/Lib/Batch/BatchScriptTemplate.py.template:#!/usr/bin/env python2
GangaCore/Lib/Notebook/Notebook.py:                defvalue='python2',
GangaCore/test/GPI/Notebook/Test.ipynb:   "name": "python2"
GangaCore/test/GPI/Notebook/Test.ipynb:   "pygments_lexer": "ipython2",
GangaDirac/Lib/RTHandlers/ExeDiracRTHandler.py:    script_template = """#!/usr/bin/env python2
GangaLHCb/Lib/RTHandlers/ExeDiracRTHandler.py:    script_template = """#!/usr/bin/env python2
@souravpy
Copy link
Contributor

souravpy commented Jan 7, 2024

Should this be updated to latest python version 3.14?

@egede
Copy link
Member Author

egede commented Jan 8, 2024

Should this be updated to latest python version 3.14?

No, I think it should just be updated to say python3 instead of python2. And the scripts should be updated if they have something in them that is not python3 valid syntax. These are simple wrapper scripts, so they should be kept as "version agnostic" as possible as we do not have control of the exact version used (could be anything at the moment between 3.6 and 3.14).

souravpy added a commit to souravpy/ganga that referenced this issue Jan 12, 2024
Remove legacy python2 dependencies ganga-devs#2222
souravpy added a commit to souravpy/ganga that referenced this issue Jan 12, 2024
souravpy added a commit to souravpy/ganga that referenced this issue Jan 12, 2024
souravpy added a commit to souravpy/ganga that referenced this issue Jan 12, 2024
@mesmith75
Copy link
Contributor

Fixed by #2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants