Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with headings #6

Open
Brand3000 opened this issue Sep 26, 2022 · 2 comments
Open

Issue with headings #6

Brand3000 opened this issue Sep 26, 2022 · 2 comments

Comments

@Brand3000
Copy link

Hi!
If there's a Heading::make field in a resource, it becomes required while using nova-callbacks package. Actually, I modified
(new static($model))->updateFieldsWithoutReadonly($request)
to
(new static($model))
->updateFields($request)
->applyDependsOn($request)
->withoutReadonly($request)
->withoutUnfillable()

and analogically in the fill method.

@ganyicz
Copy link
Owner

ganyicz commented Sep 30, 2022

Hi! is this package still relevant with Nova 4? I saw there are callbacks similar to what this package provides

@r0bdiabl0
Copy link

Hi! is this package still relevant with Nova 4? I saw there are callbacks similar to what this package provides
I believe you are referring to Action Callbacks. The problem with Action callbacks is you have to define a specific action that you then click from a menu and it fires your callbacks.

I want to be able to handle callbacks just from using the application by updates and saves, etc... For instance, whenever a role is attached to a user, send them an email. I don't want to have to create an action for each role when I can just check to see if the role is attached on save and then dispatch my event. Otherwise I'd have 100's of actions for each role and what I want to fire against it.

Based on this, is your package still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants