Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve overshooting logic #346

Closed
Tracked by #724
prashanth26 opened this issue Oct 30, 2019 · 2 comments
Closed
Tracked by #724

Improve overshooting logic #346

prashanth26 opened this issue Oct 30, 2019 · 2 comments
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/4 Priority (lower number equals higher priority) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)

Comments

@prashanth26
Copy link
Contributor

Issue

Machine safety controller only checks for machine objects while overshooting VMs

Solution

Machine safety controller to check infra VMs instead of machine objects while freezing for overshooting.
@prashanth26 prashanth26 added kind/enhancement Enhancement, improvement, extension size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/under-investigation Issue is under investigation labels Oct 30, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 30, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 28, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 29, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 29, 2020
@prashanth26 prashanth26 removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label Aug 13, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 13, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 13, 2020
@gardener-robot gardener-robot added effort/2w Effort for issue is around 2 weeks and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
@prashanth26 prashanth26 added the priority/4 Priority (lower number equals higher priority) label Jul 21, 2021
@elankath
Copy link
Contributor

elankath commented Feb 21, 2023 •
edited
Loading

Grooming Discussion Results:

  1. Nobody knows why current overshooting freeze logic checks for machine object count instead of VM (aka instance) count. History on this was lost and not captured in issue.
  2. The use-case for user-driven overshooting freeze is understood but why should automatic freeze be necessary is still not clear. Is it just a nice to have safety net or needed from past experience.
  3. Currently only the MachineSet controller ignores replica change when overshooting freeze is enabled. The Machine Deployment controller only logs the overshooting freeze condition.
  4. Machine Set Overshooting freeze is separate and independent from Machine Controller lifecycle freeze.
  5. Some limited background for original motivation of this feature covered in Garbage collector for machine-controller-manager #3

@himanshu-kun himanshu-kun added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) needs/planning Needs (more) planning with other MCM maintainers and removed lifecycle/rotten Nobody worked on this for 12 months (final aging stage) status/under-investigation Issue is under investigation effort/2w Effort for issue is around 2 weeks labels Feb 21, 2023
@himanshu-kun himanshu-kun mentioned this issue Feb 21, 2023
Open
49 tasks
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 31, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 9, 2024
@aaronfern aaronfern mentioned this issue Jan 17, 2025
Open
@aaronfern
Copy link
Contributor

Currently we lack details about why this logic was introduced. Will be re-looked at during the overhaul #895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/4 Priority (lower number equals higher priority) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@elankath @prashanth26 @gardener-robot @aaronfern @himanshu-kun