Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all validation and defaulting to External WebHook #43

Closed
mvladev opened this issue Mar 6, 2018 · 2 comments
Closed

Move all validation and defaulting to External WebHook #43

mvladev opened this issue Mar 6, 2018 · 2 comments
Labels
component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) effort/1m Effort for issue is around 1 month kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/3 Priority (lower number equals higher priority) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/accepted Issue was accepted as something we need to work on

Comments

@mvladev
Copy link

mvladev commented Mar 6, 2018

Validation and defaulting, should happen, before the resource is committed in the etcd. No validation or defaulting should happen in the controller: docs, setup, implementation
@prashanth26 prashanth26 added the kind/enhancement Enhancement, improvement, extension label Apr 26, 2018
@vlerenc vlerenc added the status/accepted Issue was accepted as something we need to work on label Aug 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 5, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 4, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 6, 2019
@gardener-robot-ci-2 gardener-robot-ci-2 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 6, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 6, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Feb 5, 2020
@ghost ghost added component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) and removed component/machine-controller-manager labels Mar 7, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 7, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 7, 2020
@prashanth26 prashanth26 mentioned this issue Jul 21, 2021
Closed
@prashanth26 prashanth26 added effort/1m Effort for issue is around 1 month priority/5 Priority (lower number equals higher priority) labels Jul 21, 2021
@himanshu-kun himanshu-kun added the priority/3 Priority (lower number equals higher priority) label Feb 20, 2023
@gardener-robot gardener-robot removed the priority/5 Priority (lower number equals higher priority) label Feb 20, 2023
@himanshu-kun himanshu-kun added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed lifecycle/rotten Nobody worked on this for 12 months (final aging stage) labels Feb 20, 2023
@elankath
Copy link
Contributor

Currently validation of objects like MachineClass only happen when a corresponding Machine for this is created. We will handle this in the controller runtime migration.

@himanshu-kun himanshu-kun added the needs/planning Needs (more) planning with other MCM maintainers label Feb 20, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 30, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 8, 2024
@aaronfern
Copy link
Contributor

This will be handled in #895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) effort/1m Effort for issue is around 1 month kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/3 Priority (lower number equals higher priority) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/accepted Issue was accepted as something we need to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@vlerenc @elankath @mvladev @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot @aaronfern @himanshu-kun