New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog tweaks #19

Closed

delaneyj opened this issue Jan 7, 2016 · 2 comments

delaneyj commented Jan 7, 2016

Cancel shouldn't be the a primary color, only the confirm button.
Should the buttons be more generic whereas its more about proper placement at bottom of dialog? (ie what if you want more than 2 buttons or to control the styling, relates to No Icon component #1)
If the buttons are fixed they should have default ok/cancel labels.
Setting width||height to something like '90%' offsets but does not expand the dialog contents

Owner

garth commented Jan 7, 2016

Fix coming
If you don't supply data for buttons then you can manually add any content you wish as part of children.
Buttons are not fixed, so you can leave them out and the will not appear.
All sizing in in pixels and should be provided as numbers since internally the components are doing math on the number.

garth closed this as completed in

24e26ed

Owner

garth commented Jan 7, 2016

Styling of secondary button font colour may sometimes clash with the background colour. This will be addressed with #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment