Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Password not working properly #13

Open
justinneff opened this issue Apr 22, 2017 · 2 comments
Open

Update Password not working properly #13

justinneff opened this issue Apr 22, 2017 · 2 comments
Assignees
Labels

Comments

@justinneff
Copy link
Contributor

On multiple occasions, when I publish with the login password in single quotes, the password that gets updated for login in SQL Server is not correct. I have had to go in and manually change the password correctly.

This appears to only be an issue publishing from the command line as publishing from a node script does not suffer this issue. Suspect the problem has to do with the interpretation of the quoted arguments by yargs.

@justinneff justinneff added the bug label Apr 22, 2017
@justinneff justinneff self-assigned this Apr 22, 2017
@justinneff
Copy link
Contributor Author

I have tracked it down to what appears to be an issue in the yargs library. The caret (^) character is getting removed from the parsed parameter string value. Therefore any password containing a caret are being changed to a form without the caret.

I have opened an issue on the yargs project. yargs/yargs#860

@justinneff
Copy link
Contributor Author

This is a Windows command shell issue. See this SO post. There are several characters that Windows command shell and powershell treat as special characters. The characters & | ( < > ^ are reserved characters and may cause problems.

Possible, workarounds would include reading password for a file or prompting the user for the passwords after launching the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant