Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bit of genomic intro to the basic vignette #129

Open
gregorgorjanc opened this issue Apr 1, 2023 · 7 comments
Open

Add a bit of genomic intro to the basic vignette #129

gregorgorjanc opened this issue Apr 1, 2023 · 7 comments

Comments

@gregorgorjanc
Copy link
Contributor

gregorgorjanc commented Apr 1, 2023

We can pull some material from the MOOC!

The idea is that we emphasise chromosomes and chromosome copies as it seems that many people don't know this well enough (even though they should as this is the basics of genetics).

@RosCraddock
Copy link

Happy to be assigned to this issue.

@gregorgorjanc
Copy link
Contributor Author

@RosCraddock perfect!

@gaynorr we spoke about this a while ago so I can not recall if we said that we should port some of introductory MOOC material into https://github.com/gaynorr/AlphaSimR/blob/master/vignettes/intro.Rmd or do we need another separate genomics vignette?

@gregorgorjanc
Copy link
Contributor Author

@RosCraddock @gaynorr I just gave you access to the AlphaSimR MOOC material so you can see what R vignettes/markdown material we have in there.

@RosCraddock
Copy link

@gregorgorjanc I have completed the genomic vignette: RosCraddock@ad0ab7f.
Hopefully, that covers what you were thinking. Any feedback would be great!

@gregorgorjanc
Copy link
Contributor Author

@RosCraddock this looks great!

Before I jump into editor OCD mode, one essential thing that’s missing is some AlphaSimR code.

I think that for each section (except the last) we need some AlphaSimR code to show the key concepts. You can lift from the MOOC vignettes as much as you want but I suggest you limit to bare minimum and then we point people to the course for more and for exercises etc.

Happy to revise the vignette when you add the code;)

@RosCraddock
Copy link

@gregorgorjanc Fair point! I have added some AlphaSimR code now. I will share it here, but if it is easiest, I can create a pull request to your fork or AlphaSimR.
https://github.com/RosCraddock/AlphaSimR/blob/devel/vignettes/articles/Genome.Rmd

@gregorgorjanc
Copy link
Contributor Author

gregorgorjanc commented Sep 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants