-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bit of genomic intro to the basic vignette #129
Comments
Happy to be assigned to this issue. |
@RosCraddock perfect! @gaynorr we spoke about this a while ago so I can not recall if we said that we should port some of introductory MOOC material into https://github.com/gaynorr/AlphaSimR/blob/master/vignettes/intro.Rmd or do we need another separate genomics vignette? |
@RosCraddock @gaynorr I just gave you access to the AlphaSimR MOOC material so you can see what R vignettes/markdown material we have in there. |
@gregorgorjanc I have completed the genomic vignette: RosCraddock@ad0ab7f. |
@RosCraddock this looks great! Before I jump into editor OCD mode, one essential thing that’s missing is some AlphaSimR code. I think that for each section (except the last) we need some AlphaSimR code to show the key concepts. You can lift from the MOOC vignettes as much as you want but I suggest you limit to bare minimum and then we point people to the course for more and for exercises etc. Happy to revise the vignette when you add the code;) |
@gregorgorjanc Fair point! I have added some AlphaSimR code now. I will share it here, but if it is easiest, I can create a pull request to your fork or AlphaSimR. |
Yes, please add the to the PR - best to use in line commenting
…--
With regards!
-----------------------------------------------------------------
University of Edinburgh Gregor Gorjanc, PhD
The Roslin Institute Professor & Royal Society Industry Fellow
Easter Bush @***@***.***<https://twitter.com/GregorGorjanc>
EH25 9RG @***@***.***>
Scotland, UK www.ed.ac.uk/roslin/highlanderlab<http://www.ed.ac.uk/roslin/highlanderlab>
-----------------------------------------------------------------
On Mon, Sep 9 2024 at 11:06 PM, Ros ***@***.******@***.***>> wrote:
This email was sent to you by someone outside the University.
You should only click on links or attachments if you are certain that the email is genuine and the content is safe.
@gregorgorjanc<https://github.com/gregorgorjanc> Fair point! I have added some AlphaSimR code now. I will share it here, but if it is easiest, I can create a pull request to your fork or AlphaSimR.
https://github.com/RosCraddock/AlphaSimR/blob/devel/vignettes/articles/Genome.Rmd
—
Reply to this email directly, view it on GitHub<#129 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFRGSUCWIU2AD6R2CZXA53ZVYETDAVCNFSM6AAAAABKVGKD3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGA4DSMRUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.
|
We can pull some material from the MOOC!
The idea is that we emphasise chromosomes and chromosome copies as it seems that many people don't know this well enough (even though they should as this is the basics of genetics).
The text was updated successfully, but these errors were encountered: