Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: "Announce" entry from GitHub repository #231

Open
avivace opened this issue Feb 16, 2024 · 5 comments
Open

RFC: "Announce" entry from GitHub repository #231

avivace opened this issue Feb 16, 2024 · 5 comments

Comments

@avivace
Copy link
Member

avivace commented Feb 16, 2024

So here's a simply workflow to allow a developer to submit an entry to Homebrew Hub simply "announcing" the git repository:

  • The developer creates a github repository hosting all the game files / sources etc AND a game.json manifest
  • Developer opens an issue in the database repository mentioning he wants to add a game and links the repository
  • An automated action picks up the issue and imports the folder in the database, in the current status. If the validation fails, it reports in the issue what went wrong. Validation steps:
    • game.json schema validation
    • file validation

Open questions:

  • How can the developer refer to the ROM if it's not in the git repo but e.g. in the releases?
@dag7dev
Copy link
Contributor

dag7dev commented Mar 19, 2024

I would add as open question: in case the author moves or in case of whatever takedown reason, we still would not be able to preserve that piece of software. Then?

@avivace
Copy link
Member Author

avivace commented Apr 17, 2024

I would add as open question: in case the author moves or in case of whatever takedown reason, we still would not be able to preserve that piece of software. Then?

This would be just a "trigger", so once a repository is submitted, it's data is pulled and copied into our database. I see this as a simpler way to submit (and keep metadata updated) to Homebrew Hub.

@dag7dev
Copy link
Contributor

dag7dev commented Oct 17, 2024

Isn't this duplicate of #238 ? @avivace

@avivace
Copy link
Member Author

avivace commented Oct 17, 2024

Isn't this duplicate of #238 ? @avivace

nope? this is about publishing from github, without having to PR to the database, but just "announcing" you have an homebrew repository. #238 is about signalling that you would like your homebrew to be distributed to third parties using the Homebrew Hub api

@dag7dev
Copy link
Contributor

dag7dev commented Oct 17, 2024

Isn't this duplicate of #238 ? @avivace

nope? this is about publishing from github, without having to PR to the database, but just "announcing" you have an homebrew repository. #238 is about signalling that you would like your homebrew to be distributed to third parties using the Homebrew Hub api

Whoops, you're right, thanks for pointing out this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants