Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Add missing pages to App.js #4

Open
gbowne1 opened this issue Jun 22, 2023 · 12 comments
Open

[TODO] Add missing pages to App.js #4

gbowne1 opened this issue Jun 22, 2023 · 12 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Jun 22, 2023

We will have a /page, /layout, /view, /model, /component structure

The app needs several pages in the view to which components will be rendered

The routed page in App.js needs to be fixed to refer to the actual page being displayed when navigated to.

The individual pages need to be created.


etc

They also need to be imported to App.js

@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jun 22, 2023
@itspunkaj
Copy link
Contributor

i can contribute to this too

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 22, 2023

This is a refacfor of an old project of mine that had significant issues pre React 17. I have the original layout design screen shots if you or anyone needs a design @itspunkaj

But yeah, this would help

@itspunkaj
Copy link
Contributor

you just want the pages to addded to the app.js right ?

@itspunkaj
Copy link
Contributor

import the pages for now

@itspunkaj
Copy link
Contributor

hey @gbowne1 can you tell me how you want the pages to look.

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 22, 2023

@itspunkaj I can do better than that. I can show you. It will need some changes.. but this was the overall layout was going for. It's all MUI.

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 22, 2023

Here's the general idea.. from the previous iteration..

erp1

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 22, 2023

bjndkcabpkjhhpen
lklhpbbpmcefophh

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 23, 2023

@itspunkaj after the merge, I am getting:

useLocation() may be used only in the context of a component.

@itspunkaj
Copy link
Contributor

Even I had this issue.

@itspunkaj
Copy link
Contributor

Also i cannot solve this pages issue as I don't have a lot of time . I'm sorry

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 23, 2023

I would be ok with whatever you are able to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
Development

No branches or pull requests

2 participants