-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove generated code from the repo #113
Comments
maybe server does not have to be the exception |
npm requires absolute path to "link" the generated client into the website, which makes it impossible to do it inside the docker :( |
I do not understand what that means. What is the essential part Docker environment is missing to be able to do this? |
visualization has two pieces of generated code:
generating the bundle requires full path to the client, but it uses the index.js, which is modified outside the docker during development.. |
it might be possible to make npm run inside the docker, but it would need to do so even during development. |
i am using the same generated client for my js bot too. but that would hopefully still work.. |
in the end - i think that it would be ok to remove generated code for the server, and keep the code for python and javascript. |
Conclusion:
|
provide simple makefile which will regen all those (in docker = no user deps needed)
The text was updated successfully, but these errors were encountered: