Currently useless CodeValidator's method validate_program

[ecol-master]

File Location(s)

Source file: utils/wasm-builder/src/code_validator.rs

impl CodeValidator {
    pub fn validate_program(self) -> anyhow::Result<()> {
        match Code::try_new(
            self.code,
            1,
            |_| CustomConstantCostRules::default(),
            None,
            None,
            None,
        ) {
            Err(code_error) => Err(CodeErrorWithContext::from((self.module, code_error)))?,
            _ => Ok(()),
        }
    }
    ...
}

Proposal

Currently, the validate_program method in the CodeValidator class is ineffective. All the parameters which are influnce to validation are set to None, and there is no actual validation of the program’s code being performed.

I propose to add something likeWasmProjectSetting with fields like: code_validation: true.
It will help to increase performance in code postprocessing

Source: utils/wasm-builder/src/wasm_project.rs line 514:

for (wasm_path, _) in &wasm_files {
    let code = fs::read(wasm_path)?;
    let validator = CodeValidator::try_from(code)?;

    if self.project_type.is_metawasm() {
        validator.validate_metawasm()?;
    } else {
        validator.validate_program()?;
    }
}

[StackOverflowExcept1on]

You can fix this using gear_core::gas_metering, specifically Schedule. It is necessary to copy pallet-gear.

gear/pallets/gear/src/lib.rs

Lines 1163 to 1170 in 25a331d

	let code = Code::try_new(
	code,
	schedule.instruction_weights.version,
	|module| schedule.rules(module),
	schedule.limits.stack_height,
	schedule.limits.data_segments_amount.into(),
	schedule.limits.table_number.into(),
	)

[StackOverflowExcept1on]

Also do not change validate_metawasm as it will be removed soon.