Skip to content

Commit

Permalink
Fix tests and method names
Browse files Browse the repository at this point in the history
  • Loading branch information
Benedek Dévényi committed Jan 19, 2025
1 parent 74eeeee commit 4b470a6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions cozy/media/tag_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ def _get_chapters(self):
mutagen_file = File(path)

if isinstance(mutagen_file, MP4):
return self._get_mp4_chapter(mutagen_file)
return self._get_mp4_chapters(mutagen_file)
elif isinstance(mutagen_file, MP3):
return self._get_mp3_chapter(mutagen_file)
return self._get_mp3_chapters(mutagen_file)
else:
return self._get_single_file_chapter()

Expand Down Expand Up @@ -140,7 +140,7 @@ def _get_single_file_chapter(self):
)
return [chapter]

def _get_mp4_chapter(self, file: MP4) -> list[Chapter]:
def _get_mp4_chapters(self, file: MP4) -> list[Chapter]:
if not file.chapters or len(file.chapters) == 0:
return self._get_single_file_chapter()

Expand All @@ -163,7 +163,7 @@ def _get_mp4_chapter(self, file: MP4) -> list[Chapter]:

return chapters

def _get_mp3_chapter(self, file: MP3) -> list[Chapter]:
def _get_mp3_chapters(self, file: MP3) -> list[Chapter]:
chaps = file.tags.getall("CHAP")
if not chaps:
return self._get_single_file_chapter()
Expand Down
4 changes: 2 additions & 2 deletions test/cozy/media/test_tag_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def test_get_m4b_chapters(mocker, discoverer_mocks):
from cozy.media.tag_reader import TagReader

tag_reader = TagReader("file://abc/def/01 a nice file.m4b", discoverer_mocks.info)
chapters = tag_reader._get_m4b_chapters(M4B([M4BChapter("test", 0), M4BChapter("testa", 1)]))
chapters = tag_reader._get_mp4_chapters(M4B([M4BChapter("test", 0), M4BChapter("testa", 1)]))

assert len(chapters) == 2
assert chapters[0].name == "test"
Expand All @@ -144,7 +144,7 @@ def test_get_m4b_chapters_creates_single_chapter_if_none_present(mocker, discove
from cozy.media.tag_reader import TagReader

tag_reader = TagReader("file://abc/def/01 a nice file.m4b", discoverer_mocks.info)
chapters = tag_reader._get_m4b_chapters(M4B([]))
chapters = tag_reader._get_mp4_chapters(M4B([]))

assert len(chapters) == 1
assert chapters[0].name == "a nice file"
Expand Down

0 comments on commit 4b470a6

Please sign in to comment.