Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildDiffOpts.antialiasingTolerance doesn't seem to be making any difference #446

Closed
drairi opened this issue Sep 26, 2019 · 2 comments
Closed

Comments

@drairi
Copy link

drairi commented Sep 26, 2019

Am i doing something wrong here?

My config includes:

module.exports = {
  tolerance: 10,
  buildDiffOpts: {
    antialiasingTolerance: 10
  }
}

My test code includes:

it('Photofeature', function() {
  return this.browser
    .url('https://www.dr.dk/mitliv/martin-er-faldet-en-dvaerg-og-mette-har-giftet-sig-med-en-hjerneskadet')
    .assertView('Photofeature', '.dre-article');
});

I test on Browserstack, and i particularly get problems with Windows 10 Edge. Which looks to me very much like antialiasing problems, but no matter the tolerance or buildDiffOpts.antialiasingTolerance levels i set, i still get the problem.

Am i doing something wrong? Is this actually not an antialiasing problem but an alpha problem?

You can find the images it has produced here:

Baseline:
https://user-images.githubusercontent.com/44468637/65691884-eafebc80-e071-11e9-942c-438cfcc667e7.png

Actual:
https://user-images.githubusercontent.com/44468637/65691893-ef2ada00-e071-11e9-84ef-899338b3651b.png

Diff:
https://user-images.githubusercontent.com/44468637/65691919-f9e56f00-e071-11e9-9483-f853b2b97094.png

Closeup showing problematic pixels:
image

Why isn't this being resolved by ignoring antialiasing?

Hermione version: 2.12.6

@drairi
Copy link
Author

drairi commented Sep 27, 2019

Ah, this is definitely not a hermione bug. I've tried these two images directly with looks-same and the antialiasingTolerance makes no difference. I had to increase tolerance to 20 before it started to pass. I'll raise an issue there.

@drairi drairi closed this as completed Sep 27, 2019
@drairi
Copy link
Author

drairi commented Sep 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant