ProjectProvenanceReview

Overview

This is the pygeoapi code providence review, covering issues raised for each module in the project during the OSGeo Incubation process. The goal here is to check the file headers (fill them in if needed) and confirm that the information is correct. The associated ticket is https://github.com/geopython/pygeoapi/issues/790

Code review

Code review is done as an automated process:

# find all code files
find . -type f -name "*.py"
# find all code files that do not have copyright assigned
find . -name "*.py" | xargs egrep -L -i -H '(.+)Copyright \(c\) 20.. (.+)'
# find all code files with code snippets which are lifted from elsewhere
find . -type f -name "*.py" | xargs egrep "\#.*http"

Key	Definition
❔	not checked yet
❓	check in progress
❓ ❗	check is stuck, header or license requires developer attention
✅ ✔️	checked, all clear
✅ ❗	checked, warning (missing information)
✅ ‼️	checked, fix me! requires developer attention

A typical pygeoapi code header can be found in https://github.com/geopython/pygeoapi/blob/master/setup.py#L1-L28

Status	File	Comments
✅ ✔️	./pygeoapi/l10n.py
✅ ✔️	./pygeoapi/config.py
✅ ✔️	./pygeoapi/log.py
✅ ❗	./pygeoapi/util.py	Contains magazine code (https://stackoverflow.com/a/55301129)
✅ ✔️	./pygeoapi/openapi.py
✅ ✔️	./pygeoapi/provider/csv_.py
✅ ✔️	./pygeoapi/provider/tile.py
✅ ✔️	./pygeoapi/provider/postgresql.py
✅ ✔️	./pygeoapi/provider/mongo.py
✅ ✔️	./pygeoapi/provider/base_edr.py
✅ ✔️	./pygeoapi/provider/sensorthings.py
✅ ✔️	./pygeoapi/provider/filesystem.py
✅ ✔️	./pygeoapi/provider/init.py
✅ ✔️	./pygeoapi/provider/xarray_.py
✅ ✔️	./pygeoapi/provider/xarray_edr.py
✅ ✔️	./pygeoapi/provider/sqlite.py
✅ ✔️	./pygeoapi/provider/tinydb_.py
✅ ✔️	./pygeoapi/provider/mvt.py
✅ ✔️	./pygeoapi/provider/hateoas.py
✅ ✔️	./pygeoapi/provider/ogr.py
✅ ✔️	./pygeoapi/provider/rasterio_.py
✅ ✔️	./pygeoapi/provider/geojson.py
✅ ✔️	./pygeoapi/provider/elasticsearch_.py
✅ ✔️	./pygeoapi/provider/base.py
✅ ✔️	./pygeoapi/init.py
✅ ✔️	./pygeoapi/models/init.py
✅ ✔️	./pygeoapi/models/cql.py
✅ ✔️	./pygeoapi/api.py
✅ ✔️	./pygeoapi/linked_data.py
✅ ✔️	./pygeoapi/formatter/csv_.py
✅ ✔️	./pygeoapi/formatter/init.py
✅ ✔️	./pygeoapi/formatter/base.py
✅ ✔️	./pygeoapi/plugin.py
✅ ✔️	./pygeoapi/flask_app.py
✅ ✔️	./pygeoapi/starlette_app.py
✅ ✔️	./pygeoapi/process/hello_world.py
✅ ✔️	./pygeoapi/process/init.py
✅ ✔️	./pygeoapi/process/manager/init.py
✅ ✔️	./pygeoapi/process/manager/tinydb_.py
✅ ✔️	./pygeoapi/process/manager/dummy.py
✅ ✔️	./pygeoapi/process/manager/base.py
✅ ✔️	./pygeoapi/process/base.py
✅ ✔️	./tests/test_ogr_wfs_provider.py
✅ ✔️	./tests/test_postgresql_provider.py
✅ ✔️	./tests/test_xarray_zarr_provider.py
✅ ✔️	./tests/test_l10n.py
✅ ✔️	./tests/test_tinydb_manager_for_parallel_requests.py
✅ ✔️	./tests/test_csv__formatter.py
✅ ✔️	./tests/test_elasticsearch__provider.py
✅ ✔️	./tests/util.py
✅ ✔️	./tests/test_ogr_sqlite_provider.py
✅ ✔️	./tests/test_csv__provider.py
✅ ✔️	./tests/load_es_data.py
✅ ✔️	./tests/test_openapi.py
✅ ✔️	./tests/load_sta_data.py
✅ ✔️	./tests/test_tinydb_catalogue_provider.py
✅ ✔️	./tests/init.py
✅ ✔️	./tests/test_ogr_gpkg_provider.py
✅ ✔️	./tests/load_tinydb_records.py
✅ ✔️	./tests/test_util.py
✅ ✔️	./tests/test_geojson_provider.py
✅ ✔️	./tests/test_filesystem_provider.py
✅ ✔️	./tests/test_ogr_shapefile_provider.py
✅ ✔️	./tests/test_mongo_provider.py
✅ ✔️	./tests/test_ogr_csv_provider.py
✅ ✔️	./tests/test_ogr_esrijson_provider.py
✅ ✔️	./tests/test_config.py
✅ ✔️	./tests/test_sqlite_geopackage_provider.py
✅ ✔️	./tests/test_api.py
✅ ✔️	./tests/test_xarray_netcdf_provider.py
✅ ✔️	./tests/load_mongo_data.py
✅ ✔️	./tests/test_rasterio_provider.py
✅ ✔️	./tests/test_sensorthings_provider.py
✅ ‼️	./aws-lambda/container/wsgi.py	Missing source code header
✅ ✔️	./docs/source/conf.py
✅ ✔️	./setup.py

Documentation review

Documentation is expected to be under a license such as Creative Commons by Attribution:

• Docs are in https://github.com/geopython/pygeoapi/tree/master/docs
• under licensed under a Creative Commons Attribution 4.0 International (CC BY 4.0) License: https://github.com/geopython/pygeoapi/blob/master/docs/source/conf.py#L100

Data

This is the data we distribute, we want to ensure we have obtained permission. The priority is the data bundled with our application.

• Data is at https://github.com/geopython/pygeoapi/tree/master/tests/data
• Data sources are documented at https://github.com/geopython/pygeoapi/tree/master/tests/data/README.md
• Data is scoped to regression testing
• Data is not bundled or distributed with the application

TODO: some files are not in the README.md

Copyright Holders

This is a list compiled through the Provenance Review, of all copyright holders listed in the source files. This list is of essentially everyone who would need to agree to relicense the project.

Copyright holder review is done as an automated process:

find . -name "*.py" | xargs egrep  -i -H '(.+)Copyright \(c\) 20.. (.+)'|awk -F: '{print $2}'|sort -u|awk -F20.. '{print $2}'|sort -u

List as of 2022-04-18 (in alphabetical order):

• 52°North Spatial Information Research GmbH
• Benjamin Webb
• Francesco Bartoli
• GeoCat BV
• Gregory Petrochenkov
• Jorge Samuel Mendes de Jesus
• Just van den Broecke
• Matthew Perry
• Timo Tuunanen
• Tom Kralidis
• Yves Choquette