Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq - get rid of the xml configuration files ? #144

Open
pmauduit opened this issue Sep 12, 2024 · 1 comment
Open

rabbitmq - get rid of the xml configuration files ? #144

pmauduit opened this issue Sep 12, 2024 · 1 comment

Comments

@pmauduit
Copy link
Member

It would be a more "spring-boot'-ish approach to use configuration classes, instead of the 2 xml configuration files from the classpath:

@pmauduit
Copy link
Member Author

pmauduit commented Sep 12, 2024

I am also questioning myself about the added value of the following class:
https://github.com/georchestra/georchestra-gateway/blob/main/gateway/src/main/java/org/georchestra/gateway/accounts/events/rabbitmq/RabbitmqEventsListener.java

It is not dead code though, but apart from parsing the message from rabbitMq and logging it, no other action is performed. I guess the intent was first to acknowledge the fact that an action had been performed console-side, but maybe we could just discard the need for a listener here, or maybe keeping it as it is for future usage ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant