Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small numerical error in mass flux regridding #377

Closed
4 tasks done
sdeastham opened this issue Feb 6, 2024 · 4 comments
Closed
4 tasks done

Small numerical error in mass flux regridding #377

sdeastham opened this issue Feb 6, 2024 · 4 comments
Assignees
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Online Regridding Related to MAPL regridding during run-time
Milestone

Comments

@sdeastham
Copy link
Contributor

Name and Institution (Required)

Name: Seb Eastham
Institution: Imperial College London

Confirm you have reviewed the following documentation

Description of your issue or question

There is a small bug in the algorithm used to handle regridding of mass fluxes between resolutions, where an edge length multiplication is missing (see GEOS-ESM/MAPL#1199). This error is resolved by some work done by Tom Clune in GEOS-ESM/MAPL#2056 (partially described in GEOS-ESM/MAPL#1202).

@lizziel lizziel added this to the 14.4.0 milestone Feb 6, 2024
@lizziel lizziel self-assigned this Feb 6, 2024
@lizziel lizziel added the category: Bug Something isn't working label Feb 6, 2024
@lizziel lizziel removed this from the 14.4.0 milestone Feb 28, 2024
@lizziel
Copy link
Contributor

lizziel commented Feb 28, 2024

I implemented the changes in GEOS-ESM/MAPL#2056 and compared before and after using GEOS-FP mass fluxes. The result is no differences in diagnostics and restart files.

@lizziel lizziel added never stale Never label this issue as stale topic: Online Regridding Related to MAPL regridding during run-time labels Mar 20, 2024
@lizziel
Copy link
Contributor

lizziel commented Jun 17, 2024

I revisited this after discussion with Tom Clune at GMAO. I pared down the updates in GEOS-ESM/MAPL#2056 to only what we need and tried again. I now see differences, although I suspect the issue before what error on my part in putting in the update.

Here is an example of differences in daily mean after a 1-day run.

Screen Shot 2024-06-17 at 3 31 26 PM

This update can go into 14.4.1 and I will create a PR.

@lizziel
Copy link
Contributor

lizziel commented Jun 18, 2024

See MAPL PR geoschem/MAPL#36 for this update.

@msulprizio msulprizio removed this from the 14.4.1 milestone Jun 28, 2024
@lizziel lizziel added this to the 14.4.2 milestone Jul 11, 2024
@lizziel
Copy link
Contributor

lizziel commented Jul 11, 2024

Now merged.

@lizziel lizziel closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Online Regridding Related to MAPL regridding during run-time
Projects
None yet
Development

No branches or pull requests

3 participants