pgconfig: Refactor layer and group repos with PublishedInfo superclass #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces `PgconfigPublishedInfoRepository` as a common superclass for `PgconfigLayerRepository` and `PgconfigLayerGroupRepository`, improving code reuse and enabling optimized querying of `PublishedInfo` objects in the `pgconfig` backend. It enhances `PgconfigCatalogFacade` with a dedicated, read-only `PgconfigPublishedInfoReadOnlyRepository` for efficient `PublishedInfo` queries. Key changes: - Added `PgconfigPublishedInfoRepository` as an abstract base for layer and layer group repositories, centralizing common logic. - Introduced `PgconfigPublishedInfoReadOnlyRepository` for read-only `PublishedInfo` access, integrated into `PgconfigCatalogFacade` for direct query and count operations, bypassing separate layer/group queries. - Updated `CatalogInfoRowMapper` to be generic and actually implement RowMapper, removing static factory methods using lambdas per cataloginfo type in favor of a configurable `newInstance()` approach. - Enhanced repository base class `PgconfigCatalogInfoRepository` with type safety and SQL generation utilities (e.g., `select()`). - Adjusted dependent repositories (`Namespace`, `Store`, `Resource`, `Style`, `Workspace`) to use the new generic row mapper and type-safe constructor. Impact: - Reduces code duplication and improves maintainability for published info handling. - Boosts query performance by leveraging a unified `PublishedInfo` repository, avoiding merge-sort overhead in the default facade implementation. - Prepares the backend for future optimizations using materialized tables. No database schema changes are included in this commit; it focuses on code structure and runtime efficiency.
groldan
force-pushed
the
pgconfig/publishedinfo_repository_superclass
branch
from
80e29ee to
2854585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
PgconfigPublishedInfoRepositoryas a common superclass forPgconfigLayerRepositoryandPgconfigLayerGroupRepository, improving code reuse and enabling optimized querying ofPublishedInfoobjects in thepgconfigbackend. It enhancesPgconfigCatalogFacadewith a dedicated, read-onlyPgconfigPublishedInfoReadOnlyRepositoryfor efficientPublishedInfoqueries.Key changes:
PgconfigPublishedInfoRepositoryas an abstract base for layer and layer group repositories, centralizing common logic.PgconfigPublishedInfoReadOnlyRepositoryfor read-onlyPublishedInfoaccess, integrated intoPgconfigCatalogFacadefor direct query and count operations, bypassing separate layer/group queries.CatalogInfoRowMapperto be generic and actually implement RowMapper, removing static factory methods using lambdas per cataloginfo type in favor of a configurablenewInstance()approach.PgconfigCatalogInfoRepositorywith type safety and SQL generation utilities (e.g.,select()).Namespace,Store,Resource,Style,Workspace) to use the new generic row mapper and type-safe constructor.Impact:
PublishedInforepository, avoiding merge-sort overhead in the default facade implementation.No database schema changes are included in this commit; it focuses on code structure and runtime efficiency.