Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10818 Review and uniform all confirmation modals according to a common design. #10851

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

anup39
Copy link

@anup39 anup39 commented Feb 25, 2025

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#10818

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

…components/layout and fixed the related imports
…,CloseButton,ConfigureMapStep,ConfigureMapTemplates,ConfirmClear,ConfirmDelete,withDelete,withConfirm,ConfirmFeatureClose
…nent as title , should disable confirm button when disabled prop is true
… props to handle additional data in title and desc, updated DeleteLayer, DeleteGroup, DeleteWidget component with new ConfirmDialog
@anup39 anup39 added New Feature used for new functionalities MapStore 3 labels Feb 25, 2025
@anup39 anup39 added this to the 2025.01.00 milestone Feb 25, 2025
@anup39 anup39 self-assigned this Feb 25, 2025
@anup39 anup39 linked an issue Feb 25, 2025 that may be closed by this pull request
4 tasks
@allyoucanmap allyoucanmap marked this pull request as draft February 25, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MapStore 3 New Feature used for new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and uniform all modals according to a common design
1 participant