Skip to content
This repository has been archived by the owner on Apr 7, 2019. It is now read-only.

Maximum macro length #124

Closed
Tom-Nelson opened this issue Sep 10, 2017 · 6 comments
Closed

Maximum macro length #124

Tom-Nelson opened this issue Sep 10, 2017 · 6 comments

Comments

@Tom-Nelson
Copy link

Hi Gerrit,
Not so much an issue as a question. It looks to me like the maximum length of a macro is 25 lines. This is probably fine 99% of the time, but I have a probing routine that runs just over (Murphy's law!). Longer macros can be created and saved, the full content appears in the user.config file, but when they execute they just stop at line 25.

I'm fairly comfortable digging around in vb.net so if you could point me in the general direction to tweak this, it would be much appreciated

@gerritv
Copy link
Owner

gerritv commented Sep 10, 2017

I just did a simplistic test to see if it is easy to replicate, no luck:
issue124

One major risk/problem with current implementation is that I don't wait for an Ok response before sending the next line. With some commands this might be a problem, e.g. anything that reads/writes from eeprom.

@Tom-Nelson
Copy link
Author

Tom-Nelson commented Sep 11, 2017 via email

@gerritv
Copy link
Owner

gerritv commented Sep 11, 2017

Unfortunately the images did not arrive at Github :-(

@Tom-Nelson
Copy link
Author

Here's the image again, hope it come through this time
image

@gerritv
Copy link
Owner

gerritv commented Sep 12, 2017

I think we are back to the core problem with my terrible implementation of macro stream to Grbl, reference Issue #61. The commands after 25th would have had to wait for room in grbl's buffer.

@Tom-Nelson
Copy link
Author

Thanks for the feedback. I suspect macros are seldom more than a few lines long so I can understand that this is a pretty low priority item. I'll close this issue since you probably already have macro handling on a to-do list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants