Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dualcurrency input field as in the Alby extension #35

Closed
bumi opened this issue May 9, 2023 · 5 comments
Closed

Use dualcurrency input field as in the Alby extension #35

bumi opened this issue May 9, 2023 · 5 comments

Comments

@bumi
Copy link
Contributor

bumi commented May 9, 2023

image
@rolznz rolznz mentioned this issue May 11, 2023
Open
@hvoecking
Copy link
Contributor

Which provider to use to get the current BTC market price in different Fiat currencies? Is there a free one that is suitable for this?

@bumi
Copy link
Contributor Author

bumi commented Nov 13, 2024

we use this: https://github.com/getAlby/js-lightning-tools?tab=readme-ov-file#-fiat-conversions

and I think we can check the alby extension how the field is implemented there.

hvoecking added a commit to hvoecking/ZapPlanner that referenced this issue Nov 17, 2024
@hvoecking
feat: use DualCurrency input field (getAlby#35)
5e123f5
@hvoecking hvoecking mentioned this issue Nov 17, 2024
Merged
@hvoecking
Copy link
Contributor

hvoecking commented Nov 17, 2024 •
edited
Loading

we use this: https://github.com/getAlby/js-lightning-tools?tab=readme-ov-file#-fiat-conversions

and I think we can check the alby extension how the field is implemented there.

Great, thank you! I used the conversion functions and implemented the interface changes accordingly

@hvoecking
Copy link
Contributor

I'm also half way through implementing #44 which builds upon the changes introduced here

rolznz added a commit that referenced this issue Jan 3, 2025
@hvoecking @rolznz
feat: use DualCurrency input field (#35) (#67)
75186b0 
* feat: use DualCurrency input field (#35)

* chore: minor ui improvements

---------

Co-authored-by: Roland Bewick <[email protected]>
@rolznz
Copy link
Contributor

rolznz commented Jan 3, 2025

closed by #67

@rolznz rolznz closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bumi @hvoecking @rolznz