Review arm64 install script

[rolznz]

It is prefixed with pi which is not right in my opinion as this is for any arm64 machine?

Also, the script could be updated to ensure the script is run from within the right directory (see updates to the amd64 script here: #978)

[rdmitr]

Not sure to be honest. Thing is, the arm64 script we have for Raspberry Pi is considerably different from the one we have for x86_64 Linux. It does bold things which are OK for a single-purpose embedded system like Raspberry Pi but fairly dubious for a desktop/server, such as binding to port 80, limiting CPU quota, and unconditionally installing the systemd service.

Instead I would suggest adapting the x86_64 script to handle both architectures for desktops and servers, and leaving the Raspberry Pi one separate. Or maybe combine them all and provide some sane defaults for all environments with options to override 🤔 WDYT?

[rolznz]

@rdmitr thanks for looking into it. I think it would be good to keep the scripts as simple as possible and probably just add one more script for arm64 (Non-PI version) based on the existing x86 script. Does that sound ok?

[rdmitr]

Yeah, the only downside I see is that we'll get more code to maintain. For our scripts, the only difference between x86_64 and desktop ARM64 seems to be the name of the downloaded file, and it's trivial to choose the appropriate one by checking the current arch with uname. But if you feel it's not worth the hassle, I'm cool with separate scripts, of course 🙂

[rolznz]

@bumi do you have any thoughts?